Incorrect translation of Ping error codes

[filipnavara]

Spotted in #62559:

On non-Windows the error code in raw-socket Ping code path is translated incorrectly:

• runtime/src/libraries/System.Net.Ping/src/System/Net/NetworkInformation/IcmpV4MessageConstants.cs

  Line 80 in 57bfe47

  return IPStatus.TimeExceeded;

• runtime/src/libraries/System.Net.Ping/src/System/Net/NetworkInformation/IcmpV6MessageConstants.cs

  Lines 79 to 84 in 57bfe47

  	case IcmpV6TimeExceededCode.HopLimitExceeded:
  	return IPStatus.TimeExceeded;
  	case IcmpV6TimeExceededCode.FragmentReassemblyTimeExceeded:
  	return IPStatus.TtlReassemblyTimeExceeded;
  	default:
  	return IPStatus.TimeExceeded;

  
  (should be TtlExpired instead of TimeExceeded)

In the non-privileged code path running the ping command line utility it will presumably return TimeExceeded without an address. The SendPingToExternalHostWithLowTtlTest outer loop test should be modified accordingly to detect this case.

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Spotted in #62559:

On non-Windows the error code in raw-socket Ping code path is translated incorrectly:

• runtime/src/libraries/System.Net.Ping/src/System/Net/NetworkInformation/IcmpV4MessageConstants.cs

  Line 80 in 57bfe47

  return IPStatus.TimeExceeded;

• runtime/src/libraries/System.Net.Ping/src/System/Net/NetworkInformation/IcmpV6MessageConstants.cs

  Lines 79 to 84 in 57bfe47

  	case IcmpV6TimeExceededCode.HopLimitExceeded:
  	return IPStatus.TimeExceeded;
  	case IcmpV6TimeExceededCode.FragmentReassemblyTimeExceeded:
  	return IPStatus.TtlReassemblyTimeExceeded;
  	default:
  	return IPStatus.TimeExceeded;

  
  (should be TtlExpired instead of TimeExceeded)

In the non-privileged code path running the ping command line utility it will presumably return TimeExceeded without an address. The SendPingToExternalHostWithLowTtlTest outer loop test should be modified accordingly to detect this case.

Author:	filipnavara
Assignees:	-
Labels:	area-System.Net, untriaged
Milestone:	-

[karelz]

Triage: Would be good to have. Should be fairly straightforward.

[deeprobin]

Feel free to assign me 😄