Fix translation of Ping error codes #63237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-System.Net
community-contribution
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFix issue #62592 (closes #62592) Current state of implementation
/cc @filipnavara
|
Member
|
Implementation looks good 👍 Now just the (arguably annoying) test... |
wfurt
reviewed
Dec 31, 2021
Member
wfurt
left a comment
wfurt
left a comment
There was a problem hiding this comment.
generally looks good. I left some comments.
src/libraries/System.Net.Ping/src/System/Net/NetworkInformation/IcmpV4MessageConstants.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Ping/src/System/Net/NetworkInformation/IcmpV6MessageConstants.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I'll mark this PR as Ready-For-Review for once, since the actual change is ready. The only problem is the tests for which we need an infrastructure owner to give us more insight about the tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #62592 (closes #62592)
Current state of implementation
/cc @filipnavara