-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fix some outerloop tests #62559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some outerloop tests #62559
Conversation
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsMy ongoing mission to get outerloop to pass clean on my home machine.
@wfurt I'm not sure about (4). Shouldn't this test always produce TtlExpired, rather than TimeExceeded?
|
|
Thanks @filipnavara. Would you mind opening an issue for your observations above? Seems like then this assertion can be fixed as well. |
|
It seems that we may be getting little coverage of running network tests (at least, outer loop ones) without elevation. I believe all our automated test runs run elevated. (Something of a hole. Fortunately most contributors likely aren't elevated.) |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1665429251 |
|
@danmoseley backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: serialport
Applying: Fix OpenOrCreate_DeleteOnClose_UsableAsMutex
Using index info to reconstruct a base tree...
A src/libraries/System.IO.FileSystem/tests/FileStream/DeleteOnClose.cs
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): src/libraries/System.IO.FileSystem/tests/FileStream/DeleteOnClose.cs deleted in HEAD and modified in Fix OpenOrCreate_DeleteOnClose_UsableAsMutex. Version Fix OpenOrCreate_DeleteOnClose_UsableAsMutex of src/libraries/System.IO.FileSystem/tests/FileStream/DeleteOnClose.cs left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Fix OpenOrCreate_DeleteOnClose_UsableAsMutex
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
My ongoing mission to get outerloop to pass clean on my home machine.
@wfurt I'm not sure about (4). Shouldn't this test always produce TtlExpired, rather than TimeExceeded?