Skip to content

Conversation

@danmoseley
Copy link
Member

My ongoing mission to get outerloop to pass clean on my home machine.

  1. QueryDosDevice was failing with access denied on a security-related entry. Skip it.
  2. Protect tests that create a user behind a check for elevation.
  3. Increase timeout for OpenOrCreate_DeleteOnClose_UsableAsMutex which somehow timed out.
  4. Change ping test to expect TtlExpired.

@wfurt I'm not sure about (4). Shouldn't this test always produce TtlExpired, rather than TimeExceeded?

@ghost
Copy link

ghost commented Dec 9, 2021

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

My ongoing mission to get outerloop to pass clean on my home machine.

  1. QueryDosDevice was failing with access denied on a security-related entry. Skip it.
  2. Protect tests that create a user behind a check for elevation.
  3. Increase timeout for OpenOrCreate_DeleteOnClose_UsableAsMutex which somehow timed out.
  4. Change ping test to expect TtlExpired.

@wfurt I'm not sure about (4). Shouldn't this test always produce TtlExpired, rather than TimeExceeded?

Author: danmoseley
Assignees: -
Labels:

area-Meta

Milestone: -

@danmoseley danmoseley merged commit 0e4909a into dotnet:main Dec 9, 2021
@danmoseley danmoseley deleted the fix.outerloop branch December 9, 2021 17:42
@danmoseley
Copy link
Member Author

Thanks @filipnavara. Would you mind opening an issue for your observations above? Seems like then this assertion can be fixed as well.

@danmoseley
Copy link
Member Author

It seems that we may be getting little coverage of running network tests (at least, outer loop ones) without elevation. I believe all our automated test runs run elevated. (Something of a hole. Fortunately most contributors likely aren't elevated.)

@danmoseley
Copy link
Member Author

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2022

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1665429251

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2022

@danmoseley backporting to release/6.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: serialport
Applying: Fix OpenOrCreate_DeleteOnClose_UsableAsMutex
Using index info to reconstruct a base tree...
A	src/libraries/System.IO.FileSystem/tests/FileStream/DeleteOnClose.cs
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): src/libraries/System.IO.FileSystem/tests/FileStream/DeleteOnClose.cs deleted in HEAD and modified in Fix OpenOrCreate_DeleteOnClose_UsableAsMutex. Version Fix OpenOrCreate_DeleteOnClose_UsableAsMutex of src/libraries/System.IO.FileSystem/tests/FileStream/DeleteOnClose.cs left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Fix OpenOrCreate_DeleteOnClose_UsableAsMutex
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants