Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vs16.9] NuGet Feed Update #6136

Merged
merged 3 commits into from
Feb 12, 2021
Merged

[vs16.9] NuGet Feed Update #6136

merged 3 commits into from
Feb 12, 2021

Conversation

dotnet-bot
Copy link
Collaborator

NuGet Feed Update

This pull request updates the usage of NuGet.org in cases where it is used in conjunction with other feeds.

Is this PR required?

Generally yes. If the target branch is no longer in use and will not need to be built in the future, please close this PR.

This PR is broken build, what do I do?

If packages are missing, please tag 'dotnet/dnceng' or 'mmitche' on this PR and note the missing packages.
If there are other unexpected failures, please contact 'dotnet/dnceng'.

Copy link
Member

@benvillalobos benvillalobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See #6135 (review)

@mmitche
Copy link
Member

mmitche commented Feb 10, 2021

Thanks, merge when ready

@benvillalobos
Copy link
Member

This branch will actually need the same update as master to nuget.config.

@mmitche
Copy link
Member

mmitche commented Feb 10, 2021

@benvillalobos Can you port the necessary changes over?

@benvillalobos
Copy link
Member

Done. Will merge when green. /cc @Forgind

@Forgind
Copy link
Member

Forgind commented Feb 10, 2021

Do you think it would make more sense to update 15.9 first and bring it forward towards 16.9 slowly? Otherwise we'll have lots of confused bots making PRs with merge conflicts that we should theoretically take...

@benvillalobos
Copy link
Member

I don't think so, wouldn't the PR's get generated regardless?

@benvillalobos
Copy link
Member

The issue this is failing on was fixed during the arcade/net 5.0 upgrade. Working on that now.

@Forgind
Copy link
Member

Forgind commented Feb 10, 2021

The idea would be that the generated PRs would (in some cases) automatically fix the problem in later versions.

@mmitche
Copy link
Member

mmitche commented Feb 10, 2021

The idea would be that the generated PRs would (in some cases) automatically fix the problem in later versions.

I would be careful with this approach unless the file structures and places that nuget.org appears are really consistent from release to release.

@benvillalobos
Copy link
Member

Glad I kicked off an exp/ branch for this. We're failing cloudbuild because of stringtools? https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/303923 this branch doesn't have ladi's change.

@benvillalobos
Copy link
Member

Actually, the VS PR is targeting master. False alarm.

Retargeted the release to rel/d16.9 and we should see a good build.

@benvillalobos
Copy link
Member

RPS passed.

@benvillalobos benvillalobos merged commit 57a23d2 into vs16.9 Feb 12, 2021
@benvillalobos benvillalobos deleted the feed-update-vs16.9 branch February 12, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants