-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vs16.9] NuGet Feed Update #6136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. See #6135 (review)
Thanks, merge when ready |
This branch will actually need the same update as master to nuget.config. |
@benvillalobos Can you port the necessary changes over? |
Done. Will merge when green. /cc @Forgind |
Do you think it would make more sense to update 15.9 first and bring it forward towards 16.9 slowly? Otherwise we'll have lots of confused bots making PRs with merge conflicts that we should theoretically take... |
fdb22e2
to
5d521ab
Compare
I don't think so, wouldn't the PR's get generated regardless? |
The issue this is failing on was fixed during the arcade/net 5.0 upgrade. Working on that now. |
The idea would be that the generated PRs would (in some cases) automatically fix the problem in later versions. |
I would be careful with this approach unless the file structures and places that nuget.org appears are really consistent from release to release. |
Glad I kicked off an exp/ branch for this. We're failing cloudbuild because of stringtools? https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/303923 this branch doesn't have ladi's change. |
Actually, the VS PR is targeting master. False alarm. Retargeted the release to rel/d16.9 and we should see a good build. |
RPS passed. |
NuGet Feed Update
This pull request updates the usage of NuGet.org in cases where it is used in conjunction with other feeds.
Is this PR required?
Generally yes. If the target branch is no longer in use and will not need to be built in the future, please close this PR.
This PR is broken build, what do I do?
If packages are missing, please tag 'dotnet/dnceng' or 'mmitche' on this PR and note the missing packages.
If there are other unexpected failures, please contact 'dotnet/dnceng'.