-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] NuGet Feed Update #6135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I expect to see a failed pipeline build after this merges because of the dotnet-core feed. It doesn't end in: dev.azure.com
or visualstudio.com
per https://docs.opensource.microsoft.com/tools/nuget_security_analysis.html
@mmitche, Maybe I'm confused, but I thought we were supposed to unify onto one feed rather than just not using public ones; is that wrong? |
@Forgind here's how the pass/fail logic works: Roughly this translates to pass/fail logic of: If the packageSources object is empty or does not exist -> Pass dev.azure.com |
@benvillalobos We should try to get rid of the dotnet-core feed too. We can migrate necessary packages off of it. |
@mmitche we're attempting to do that here: #6141 and have an experimental pipeline build running with that change here: https://dev.azure.com/devdiv/DevDiv/_build?definitionId=9434 |
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
NuGet Feed Update
This pull request updates the usage of NuGet.org in cases where it is used in conjunction with other feeds.
Is this PR required?
Generally yes. If the target branch is no longer in use and will not need to be built in the future, please close this PR.
This PR is broken build, what do I do?
If packages are missing, please tag 'dotnet/dnceng' or 'mmitche' on this PR and note the missing packages.
If there are other unexpected failures, please contact 'dotnet/dnceng'.