Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] NuGet Feed Update #6135

Merged
merged 1 commit into from
Feb 9, 2021
Merged

[master] NuGet Feed Update #6135

merged 1 commit into from
Feb 9, 2021

Conversation

dotnet-bot
Copy link
Collaborator

NuGet Feed Update

This pull request updates the usage of NuGet.org in cases where it is used in conjunction with other feeds.

Is this PR required?

Generally yes. If the target branch is no longer in use and will not need to be built in the future, please close this PR.

This PR is broken build, what do I do?

If packages are missing, please tag 'dotnet/dnceng' or 'mmitche' on this PR and note the missing packages.
If there are other unexpected failures, please contact 'dotnet/dnceng'.

Copy link
Member

@benvillalobos benvillalobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I expect to see a failed pipeline build after this merges because of the dotnet-core feed. It doesn't end in: dev.azure.com or visualstudio.com per https://docs.opensource.microsoft.com/tools/nuget_security_analysis.html

@benvillalobos benvillalobos merged commit c01c071 into master Feb 9, 2021
@benvillalobos benvillalobos deleted the feed-update-master branch February 9, 2021 18:58
@Forgind
Copy link
Member

Forgind commented Feb 9, 2021

@mmitche, Maybe I'm confused, but I thought we were supposed to unify onto one feed rather than just not using public ones; is that wrong?

@benvillalobos
Copy link
Member

@Forgind here's how the pass/fail logic works:

Roughly this translates to pass/fail logic of:

If the packageSources object is empty or does not exist -> Pass
If there is no statement present -> Fail
If one feed per file -> Pass
If multiple feeds per file (see Note below):
If all internal feeds -> Pass
If a mix of internal and external -> Fail
External feeds are considered to be those that do not end with a feed domain of:

dev.azure.com
visualstudio.com

@mmitche
Copy link
Member

mmitche commented Feb 9, 2021

@benvillalobos We should try to get rid of the dotnet-core feed too. We can migrate necessary packages off of it.

@benvillalobos
Copy link
Member

@mmitche we're attempting to do that here: #6141 and have an experimental pipeline build running with that change here: https://dev.azure.com/devdiv/DevDiv/_build?definitionId=9434

benvillalobos pushed a commit that referenced this pull request Feb 17, 2021
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
benvillalobos pushed a commit that referenced this pull request Feb 17, 2021
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
benvillalobos pushed a commit that referenced this pull request Feb 17, 2021
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
benvillalobos pushed a commit that referenced this pull request Feb 17, 2021
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants