Remove dotnet-core feed & Update GenAPI Assembly Name #6141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvillalobos
changed the title
benvillalobos
changed the title
Forgind
approved these changes
Feb 9, 2021
|
Pending a successful run of https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=4455380&view=results |
|
https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=4455487&view=results succeeded. Merging. |
benvillalobos
added a commit
that referenced
this pull request
Feb 10, 2021
benvillalobos
added a commit
that referenced
this pull request
Feb 10, 2021
KirillOsenkov
added a commit
that referenced
this pull request
Feb 16, 2021
…ource When #6141 updated from Microsoft.DotNet.BuildTools.GenAPI to Microsoft.DotNet.GenAPI our reference assembly source generation logic stopped working. Turns out the new NuGet package targets relies on singular spelling to insert itself after PrepareForRun: <PrepareForRunDependsOn Condition="'$(GenerateReferenceAssemblySource)' == 'true'"> Update our spelling to singular everywhere now that we're using the new package.
benvillalobos
added a commit
that referenced
this pull request
Feb 17, 2021
benvillalobos
added a commit
that referenced
this pull request
Feb 17, 2021
benvillalobos
added a commit
that referenced
this pull request
Feb 17, 2021
ladipro
added a commit
that referenced
this pull request
Feb 23, 2021
…emblySource When #6141 updated from Microsoft.DotNet.BuildTools.GenAPI to Microsoft.DotNet.GenAPI our reference assembly source generation logic stopped working. Turns out the new NuGet package targets relies on singular spelling to insert itself after PrepareForRun: <PrepareForRunDependsOn Condition="'$(GenerateReferenceAssemblySource)' == 'true'"> Update our spelling to singular everywhere now that we're using the new package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI
Context
The new NuGet security analysis will fail builds that don't meet certain criteria.
Microsoft.DotNet.BuildTools.GenAPIbinaries were generated by the dotnet/buildtools repo. Looking at the repo it looks like its been replaced with arcade. The arcade feed we have (dotnet-eng) contains theGenAPIbinaries under a slightly different name (buildtools removed from the name).Changes Made
Remove the dotnet-core feed because it doesn't point to an internal site.
Look for
Microsoft.DotNet.GenAPIinstead ofMicrosoft.DotNet.BuildTools.GenAPI. It exists on thedotnet-engfeed.Testing
CI will tell us if this doesn't work.
Notes
https://docs.opensource.microsoft.com/tools/nuget_security_analysis.html