[Android] Inheriting StatusBar and NavigationBar background colors on modal pages #28568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubaflo
added
platform/android
area-navigation
|
During the first implementation was a discussion of the Maui should handle that or not. I believe we chosen to not due to some edge cases. Do you remember @Redth? |
kubaflo
force-pushed
the
Changing-StatusBar-and-NavigationBar-background-color-doesn't-work-with-Modal-pages
branch
from
db81225 to
bffb022
Compare
OvrBtn
reviewed
Mar 24, 2025
| var statusBarColor = mainActivityWindow.StatusBarColor; | ||
| #pragma warning disable CA1422 | ||
| dialog.Window.SetNavigationBarColor(new AColor(navigationBarColor)); | ||
| dialog.Window.SetStatusBarColor(new AColor(statusBarColor)); |
There was a problem hiding this comment.
I've been thinking, should we maybe also take into account window.SetFlags just as it's done in here CommunityToolkit/Maui#2370 (comment) ?
But there are also other options for light/dark icons on status and navigation bar, visibility options etc.
Maybe that's why this issue was resolved the way it was using Community Toolkit?
That would also explain why there is a way to create your own implementation of this workaround to copy all the values needed https://learn.microsoft.com/en-us/dotnet/communitytoolkit/maui/platform-specific/dialogfragment-customization#create-you-own-service
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Apr 23, 2025
|
|
||
| [Test] | ||
| [Category(UITestCategories.Navigation)] | ||
| public void StatusBarAndNavigationBarShouldInheritColor() |
There was a problem hiding this comment.
Pending snapshot already available in the latest build.
Could you commit it?
| { | ||
| var navigationBarColor = mainActivityWindow.NavigationBarColor; | ||
| var statusBarColor = mainActivityWindow.StatusBarColor; | ||
| #pragma warning disable CA1422 |
There was a problem hiding this comment.
Could we detect API level and use SetSystemBarsAppearance for API 30+?
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
previously approved these changes
May 9, 2025
PureWeen
approved these changes
May 9, 2025
PureWeen
pushed a commit
that referenced
this pull request
May 13, 2025
… modal pages (#28568) * Inheriting StatusBar and NavigationBar background colors * Added snapshot
github-actions bot
pushed a commit
that referenced
this pull request
May 13, 2025
… modal pages (#28568) * Inheriting StatusBar and NavigationBar background colors * Added snapshot
PureWeen
pushed a commit
that referenced
this pull request
May 14, 2025
… modal pages (#28568) * Inheriting StatusBar and NavigationBar background colors * Added snapshot
PureWeen
pushed a commit
that referenced
this pull request
May 14, 2025
… modal pages (#28568) * Inheriting StatusBar and NavigationBar background colors * Added snapshot
github-actions bot
pushed a commit
that referenced
this pull request
May 15, 2025
… modal pages (#28568) * Inheriting StatusBar and NavigationBar background colors * Added snapshot
PureWeen
added a commit
that referenced
this pull request
May 21, 2025
For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process # .NET MAUI Release Notes ## New Release: May 21, 2025 We're excited to announce a new release of .NET MAUI with several bug fixes and improvements across various platforms. ### Bug Fixes #### iOS - **Map Control**: Fixed crash when navigating to a page containing a map more than once (#29369) - **CarouselView**: Fixed bounce-back behavior when Loop=false, ensuring proper scrolling experience (#29318) - **UIView**: Fixed NullReferenceException for UIView not being in UIWindow (#29460) #### Windows - **CarouselView**: Fixed HorizontalScrollBarVisibility="Never" not working properly (#29343) - **UI Controls**: Fixed the color not being applied to the Expand/Collapse Chevron icon (#29140) #### Windows & macOS - **Modal Navigation**: Fixed issue where Disappearing event was not triggered when closing a window with a modal page (#29129) #### Android - **Modal Pages**: Improved inheritance of StatusBar and NavigationBar background colors (#28568) - **Footer Scrolling**: Fixed footer scrolling issues in list controls (#29381) - **Modal Pages**: Improved inheritance of StatusBar and NavigationBar background colors on modal pages (#28568) #### Cross-Platform - **CarouselView**: Fixed ItemsLayout runtime updates to ensure proper layout behavior (#29447) - **CollectionView**: Fixed various issues in CollectionView implementation (#29423) ### Testing Improvements - Added feature matrix UITest cases for CollectionView dynamic changes (#29424) ### Code Quality - Fixed code formatting issues across the codebase - Minor typo corrections (#29379) ### Contributors This release was made possible by the hard work of our dedicated team and community contributors. We'd like to extend our gratitude to everyone who has contributed to this release. ### Installation This update is available through NuGet and the .NET SDK. Update your projects to get access to these fixes. ### Known Issues Please refer to our issue tracker for any known issues and their workarounds. --- For more information about .NET MAUI, visit [the official documentation](https://docs.microsoft.com/dotnet/maui/).
PureWeen
pushed a commit
that referenced
this pull request
May 21, 2025
… modal pages (#28568) * Inheriting StatusBar and NavigationBar background colors * Added snapshot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #28552
Screen.Recording.2025-03-23.at.14.45.34.mov
Screen.Recording.2025-03-23.at.14.44.26.mov