Skip to content

[Windows] Fixed the color not being applied to the Expand/Collapse Chevron icon #29140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 8, 2025

Conversation

Tamilarasan-Paranthaman
Copy link
Contributor

Root Cause of the issue

  • The NavigationViewItemForeground color was being applied to the Expand/Collapse Chevron icon within the NavigationView. However, since we did not explicitly set a value for this property in our source, the color was not applied to the icon as expected.

Description of Change

  • I updated the implementation to apply the item color (TabBarUnselectedColor) to the NavigationViewItemForeground and other relevant properties. This resolves the issue, and the color is now correctly applied to the icon.

Issues Fixed

Fixes #25115

Tested the behaviour in the following platforms

  • Windows
  • iOS
  • Android
  • Mac

Screenshot

Before Fix After Fix
Before-Fix.mp4
After-Fix.mp4

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Apr 23, 2025
Copy link
Contributor

Hey there @@Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Apr 23, 2025
@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman marked this pull request as ready for review April 23, 2025 14:53
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested a review from a team as a code owner April 23, 2025 14:53
@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz
jsuarezruiz previously approved these changes May 6, 2025
@PureWeen PureWeen changed the base branch from main to inflight/current May 8, 2025 16:16
@PureWeen PureWeen dismissed jsuarezruiz’s stale review May 8, 2025 16:16

The base branch was changed.

@PureWeen PureWeen merged commit a0382c9 into dotnet:inflight/current May 8, 2025
79 checks passed
PureWeen pushed a commit that referenced this pull request May 8, 2025
…evron icon (#29140)

* Fixed Chevron icon color issue

* Test sample changes

* Test script changes

* test sample changes

* Added Windows snapshot
PureWeen pushed a commit that referenced this pull request May 9, 2025
…evron icon (#29140)

* Fixed Chevron icon color issue

* Test sample changes

* Test script changes

* test sample changes

* Added Windows snapshot
PureWeen pushed a commit that referenced this pull request May 13, 2025
…evron icon (#29140)

* Fixed Chevron icon color issue

* Test sample changes

* Test script changes

* test sample changes

* Added Windows snapshot
github-actions bot pushed a commit that referenced this pull request May 13, 2025
…evron icon (#29140)

* Fixed Chevron icon color issue

* Test sample changes

* Test script changes

* test sample changes

* Added Windows snapshot
PureWeen pushed a commit that referenced this pull request May 14, 2025
…evron icon (#29140)

* Fixed Chevron icon color issue

* Test sample changes

* Test script changes

* test sample changes

* Added Windows snapshot
PureWeen pushed a commit that referenced this pull request May 14, 2025
…evron icon (#29140)

* Fixed Chevron icon color issue

* Test sample changes

* Test script changes

* test sample changes

* Added Windows snapshot
github-actions bot pushed a commit that referenced this pull request May 15, 2025
…evron icon (#29140)

* Fixed Chevron icon color issue

* Test sample changes

* Test script changes

* test sample changes

* Added Windows snapshot
PureWeen added a commit that referenced this pull request May 21, 2025
For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process

# .NET MAUI Release Notes

## New Release: May 21, 2025

We're excited to announce a new release of .NET MAUI with several bug
fixes and improvements across various platforms.

### Bug Fixes

#### iOS
- **Map Control**: Fixed crash when navigating to a page containing a
map more than once (#29369)
- **CarouselView**: Fixed bounce-back behavior when Loop=false, ensuring
proper scrolling experience (#29318)
- **UIView**: Fixed NullReferenceException for UIView not being in
UIWindow (#29460)

#### Windows
- **CarouselView**: Fixed HorizontalScrollBarVisibility="Never" not
working properly (#29343)
- **UI Controls**: Fixed the color not being applied to the
Expand/Collapse Chevron icon (#29140)

#### Windows & macOS
- **Modal Navigation**: Fixed issue where Disappearing event was not
triggered when closing a window with a modal page (#29129)

#### Android
- **Modal Pages**: Improved inheritance of StatusBar and NavigationBar
background colors (#28568)
- **Footer Scrolling**: Fixed footer scrolling issues in list controls
(#29381)
- **Modal Pages**: Improved inheritance of StatusBar and NavigationBar
background colors on modal pages (#28568)

#### Cross-Platform
- **CarouselView**: Fixed ItemsLayout runtime updates to ensure proper
layout behavior (#29447)
- **CollectionView**: Fixed various issues in CollectionView
implementation (#29423)

### Testing Improvements
- Added feature matrix UITest cases for CollectionView dynamic changes
(#29424)

### Code Quality
- Fixed code formatting issues across the codebase
- Minor typo corrections (#29379)

### Contributors

This release was made possible by the hard work of our dedicated team
and community contributors. We'd like to extend our gratitude to
everyone who has contributed to this release.

### Installation

This update is available through NuGet and the .NET SDK. Update your
projects to get access to these fixes.

### Known Issues

Please refer to our issue tracker for any known issues and their
workarounds.

---

For more information about .NET MAUI, visit [the official
documentation](https://docs.microsoft.com/dotnet/maui/).
PureWeen pushed a commit that referenced this pull request May 21, 2025
…evron icon (#29140)

* Fixed Chevron icon color issue

* Test sample changes

* Test script changes

* test sample changes

* Added Windows snapshot
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WinUI] Chevron doesn't get TabBarTitleColor
3 participants