Skip to content

[automated] Merge branch 'main' => 'release/dev17.14' #18332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Feb 24, 2025

Conversation

github-actions[bot]
Copy link
Contributor

I detected changes in the main branch which have not been merged yet to release/dev17.14. I'm a robot and am configured to help you automatically keep release/dev17.14 up to date, so I've opened this PR.

This PR merges commits made on main by the following committers:

  • T-Gro
  • majocha
  • ViktorHofer
  • brianrourkeboll
  • dotnet-maestro[bot]
  • auduchinok
  • edgarfgp
  • jkoritzinsky
  • KevinRansom

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout main
git pull --ff-only
git checkout release/dev17.14
git pull --ff-only
git merge --no-ff main

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet/fsharp HEAD:merge/main-to-release/dev17.14
or if you are using SSH
git push git@github.com:dotnet/fsharp HEAD:merge/main-to-release/dev17.14

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/main-to-release/dev17.14'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.

git fetch
git checkout -b merge/main-to-release/dev17.14 origin/release/dev17.14
git pull https://github.com/dotnet/fsharp merge/main-to-release/dev17.14
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet/fsharp HEAD:merge/main-to-release/dev17.14
or if you are using SSH
git fetch
git checkout -b merge/main-to-release/dev17.14 origin/release/dev17.14
git pull git@github.com:dotnet/fsharp merge/main-to-release/dev17.14
(make changes)
git commit -m "Updated PR with my changes"
git push git@github.com:dotnet/fsharp HEAD:merge/main-to-release/dev17.14

Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.

KevinRansom and others added 28 commits January 29, 2025 11:25
…ated static fields (#18280)

* Fix optimizer bug where field.Index included compiler generated static fields

* notes added
* Support for 'use' on a nullable IDisposable

* release notes
#18281)

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250128.6

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.25066.1 -> To Version 9.0.0-alpha.1.25078.6

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250131.6

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.25066.1 -> To Version 9.0.0-alpha.1.25081.6

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Petr <psfinaki@users.noreply.github.com>
…127.4 (#18282)

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.25065.2 -> To Version 9.0.0-beta.25077.4

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…pe (#18261)

* Warn when upcast drops nullness via FindUniqueFeasibleSupertype

* temporary null shutuops  before `use` is softened

* notes added
* Remove Cancellable.UsingToken from tests

The token is now always set inside the cancellable computation

* Release notes

---------

Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
* Add missing project reference from FSharpSuite to fsc project

* fix
* Symbols: add FSharpAssembly.IsFSharp

* Surface area

* Release notes
…uagePrimitves into instance method calls (#18296)

* Handle |null types when optimizing away eqals/hash/compare from function call to instance method

* Set propper test assert

* fantomas and notes

* remove comment
Contributes to dotnet/sdk#46642

NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted.
* trace test run activity

* declutter StackGuard.Guard traces

* add otel to debug vsix

* ref otel in debug only

* delay tags allocation

* fix opens

* format

* better naming
* Cancellable: fix leaking cancellation token

* Release notes

Update docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

* Set Cancellable.Token in transparent compiler

* Review fixes

* Move setting the token

* Fantomas

* Transparent compiler

* il bsl

---------

Co-authored-by: Petr <psfinaki@users.noreply.github.com>
…211.5 (#18310)

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.25077.4 -> To Version 9.0.0-beta.25111.5

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…18300)

* Resolve `nameof` in `nameof<'T>`

* Resolve `nameof` in `match … with nameof ident -> …`

* Add `nameof` classification tests

* Update release notes

* Might as well make them compilable

* Show `nameof` as keyword in `nameof<…>` even when the type parameter is invalid

* Touchup
* simplify

* add comment

* already shipped
NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted.

Resolve the one warning that got emitted when building the repository in non-source-only mode.
@github-actions github-actions bot requested review from a team as code owners February 21, 2025 11:06
Copy link
Contributor Author

❗ Release notes required


✅ Found changes and release notes in following paths:

Warning

No PR link found in some release notes, please consider adding it.

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md No current pull request URL (#18332) found, please consider adding it

@T-Gro T-Gro enabled auto-merge February 21, 2025 15:30
@T-Gro
Copy link
Member

T-Gro commented Feb 24, 2025

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@T-Gro T-Gro merged commit e4889bb into release/dev17.14 Feb 24, 2025
33 checks passed
@ViktorHofer ViktorHofer deleted the merge/main-to-release/dev17.14 branch February 24, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants