Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React to NuGet package pruning warnings #18304

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

ViktorHofer
Copy link
Member

Contributes to dotnet/sdk#46642

NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted.

Contributes to dotnet/sdk#46642

NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted.
@ViktorHofer ViktorHofer requested a review from a team as a code owner February 10, 2025 14:01
Copy link
Contributor

✅ No release notes required

@ViktorHofer ViktorHofer enabled auto-merge (squash) February 10, 2025 16:27
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this looks fine.
@VictorHofer In the future, please include a sample of the warnings that are being eliminated. It makes it easier to determine whether the fix is the right one.

Thank you

Kevin

@ViktorHofer ViktorHofer merged commit 7866d66 into main Feb 10, 2025
33 checks passed
@T-Gro T-Gro deleted the NuGetPruningReaction branch February 12, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants