Skip to content

Fix flaky tokenizer tests #18326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

Fix flaky tokenizer tests #18326

merged 1 commit into from
Feb 18, 2025

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Feb 18, 2025

Description

Make tokenizer tests thread-safe by removing shared state.

Fixes #18325

@majocha majocha requested a review from a team as a code owner February 18, 2025 00:09
@github-actions GitHub Actions
Copy link
Contributor

✅ No release notes required

psfinaki
psfinaki approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abonie abonie merged commit a2f2b00 into dotnet:main Feb 18, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonie abonie abonie approved these changes

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TokenizerTests sometimes fail
3 participants
@majocha @psfinaki @abonie