Skip to content

Add AE breaking change #18049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2020
Merged

Add AE breaking change #18049

merged 3 commits into from
Apr 24, 2020

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Apr 23, 2020 •
edited
Loading

Contributes to #17096

Internal preview link.

@gewarren gewarren requested a review from tdykstra as a code owner April 23, 2020 23:03
@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 23, 2020
@gewarren gewarren requested a review from RussKie April 23, 2020 23:04
RussKie
RussKie approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RussKie
Copy link
Contributor

RussKie commented Apr 23, 2020

The docs for System.Windows.Forms.TabControl.GetToolTipText(System.Object) be updated as well. Is this something you do, or we need to do it?

@gewarren
Copy link
Contributor Author

The docs for System.Windows.Forms.TabControl.GetToolTipText(System.Object) be updated as well. Is this something you do, or we need to do it?

Typically, the engineering team updates the API docs. We can help with PR reviews though.

tdykstra
tdykstra approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I had one question.

@gewarren gewarren merged commit a40c7cd into dotnet:master Apr 24, 2020
@gewarren gewarren deleted the argexception-tooltip branch April 24, 2020 23:22
@gewarren
Copy link
Contributor Author

Thanks for the reviews!

@gewarren gewarren mentioned this pull request Apr 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

@RussKie RussKie RussKie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
April 2020
Development

Successfully merging this pull request may close these issues.
5 participants
@gewarren @RussKie @tdykstra @BillWagner @dotnet-bot