Skip to content

Add ArgumentException and ANE to GetToolTipText #4178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 14, 2020
Merged

Add ArgumentException and ANE to GetToolTipText #4178

merged 4 commits into from
May 14, 2020

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Apr 30, 2020 •
edited
Loading

@dotnet-bot dotnet-bot added this to the May 2020 milestone Apr 30, 2020
@gewarren gewarren requested a review from RussKie April 30, 2020 00:25
@gewarren
Copy link
Contributor Author

@mairaw Did I version this exception correctly? Or is there a more sophisticated way?

<exception cref="T:System.ArgumentException">.NET 5.0 and later only: The <paramref name="item" /> parameter is not of type <see cref="T:System.Windows.Forms.TabPage" />.</exception>

@mairaw
Copy link
Contributor

mairaw commented Apr 30, 2020

Looks good to me

@gewarren gewarren changed the title Add ArgumentException to GetToolTipText Add ArgumentException and ANE to GetToolTipText May 6, 2020
@gewarren
Copy link
Contributor Author

gewarren commented May 8, 2020

@RussKie Ping for review when you get a chance. I decided it probably makes more sense for me to update the exceptions in the API docs when I'm adding the breaking changes.

@gewarren gewarren requested a review from IEvangelist May 13, 2020 16:24
IEvangelist
IEvangelist approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :shipit:

@gewarren
Copy link
Contributor Author

Thanks for reviewing David!

@gewarren gewarren merged commit dd2bcc0 into master May 14, 2020
@gewarren gewarren deleted the gewarren-patch-1 branch May 14, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

@RussKie RussKie Awaiting requested review from RussKie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
May 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@gewarren @mairaw @IEvangelist @dotnet-bot