-
Notifications
You must be signed in to change notification settings - Fork 6k
Add AE breaking change #18049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add AE breaking change #18049
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
includes/core-changes/windowsforms/5.0/invalid-args-cause-argumentexception.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
### WinForms methods now throw ArgumentException | ||
|
||
Some Windows Forms methods now throw an <xref:System.ArgumentException> for invalid arguments, where previously they did not. | ||
|
||
#### Change description | ||
|
||
Previously, passing arguments of an unexpected or incorrect type to certain Windows Forms methods would result in an indeterminate state. Starting in .NET 5.0, these methods now throw an <xref:System.ArgumentException> when passed invalid arguments. | ||
|
||
Throwing an <xref:System.ArgumentException> conforms to the behavior of the .NET runtime. It also improves the debugging experience by clearly communicating which argument is invalid. | ||
|
||
The following table lists the affected methods and parameters: | ||
|
||
| Method | Parameter name | Condition | Version added | | ||
|-|-|-| | ||
| <xref:System.Windows.Forms.TabControl.GetToolTipText(System.Object)?displayProperty=fullName> | `item` | Argument is not of type <xref:System.Windows.Forms.TabPage>. | 5.0 Preview 1 | | ||
|
||
#### Version introduced | ||
|
||
.NET 5.0 Preview 1 | ||
|
||
#### Recommended action | ||
|
||
- Update the code to prevent passing invalid arguments. | ||
- If necessary, handle an <xref:System.ArgumentException> when calling the method. | ||
|
||
#### Category | ||
|
||
Windows Forms | ||
|
||
#### Affected APIs | ||
|
||
- <xref:System.Windows.Forms.TabControl.GetToolTipText(System.Object)?displayProperty=fullName> | ||
|
||
<!-- | ||
|
||
### Affected APIs | ||
|
||
- `M:System.Windows.Forms.TabControl.GetToolTipText(System.Object)` | ||
|
||
--> |
2 changes: 1 addition & 1 deletion
2
includes/core-changes/windowsforms/5.0/null-args-cause-argumentnullexception.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.