Skip to content

Update .NET Framework GC config info #12959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Nov 9, 2019
Merged

Update .NET Framework GC config info #12959

merged 46 commits into from
Nov 9, 2019

Conversation

rpetrusha
Copy link
Contributor

@rpetrusha rpetrusha commented Jun 21, 2019 •
edited by gewarren
Loading

This PR adds 3 GC-related .NET Framework runtime configuration settings.

Fixes #11146

(The .NET Core config options will be handled in a separate PR.)

@rpetrusha rpetrusha requested a review from mairaw as a code owner June 21, 2019 20:43
@rpetrusha rpetrusha self-assigned this Jun 21, 2019
jkotas
jkotas reviewed Jun 21, 2019
View reviewed changes
jkotas
jkotas reviewed Jun 21, 2019
View reviewed changes
jkotas
jkotas reviewed Jun 21, 2019
View reviewed changes
jkotas
jkotas reviewed Jun 21, 2019
View reviewed changes
jkotas
jkotas reviewed Jun 21, 2019
View reviewed changes
jkotas
jkotas reviewed Jun 21, 2019
View reviewed changes
jkotas
jkotas reviewed Jun 21, 2019
View reviewed changes
jkotas
jkotas reviewed Jun 21, 2019
View reviewed changes
jkotas
jkotas reviewed Jun 21, 2019
View reviewed changes
@jkotas jkotas requested a review from davidwrighton June 21, 2019 22:51
Maoni0
Maoni0 reviewed Jun 22, 2019
View reviewed changes
Maoni0
Maoni0 reviewed Jun 22, 2019
View reviewed changes
@jkotas jkotas mentioned this pull request Jul 12, 2019
Closed
@mairaw
Copy link
Contributor

mairaw commented Jul 31, 2019

There are some conflicts here @rpetrusha. Do you wanna take a look?

@davidwrighton
Copy link
Member

@AaronRobinsonMSFT could you look at the environment variables around interop that @rpetrusha is documenting here? I suspect neither of these should be documented.

AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Aug 20, 2019
View reviewed changes
davidwrighton
davidwrighton approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@davidwrighton davidwrighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maoni0
Maoni0 reviewed Oct 22, 2019
View reviewed changes
docs/core/runtime-config/runtimeconfig.md Outdated
|"Switch.System.Globalization.FormatJapaneseFirstYearAsANumber"|true | false|Determines whether the first year of a Japanese calendar era is formatted as "gannen" (`false`, the default) or as a number. For more information, see [Representing dates in calendars with multiple eras](../../standard/datetime/working-with-calendars.md#representing-dates-in-calendars-with-multiple-eras).|
|"System.GC.Concurrent"|true | false|Determines whether background garbage collection is enabled (`true`, the default value) or disabled (`false`). For more information, see [Background workstation garbage collection](../../standard/garbage-collection/fundamentals.md#background-workstation-garbage-collection) and [Background server garbage collection](../../standard/garbage-collection/fundamentals.md#background-server-garbage-collection).|
|"System.GC.RetainVM"|true | false|Determines whether segments that should be deleted are put on a standby list for future use (`true`) or are released back to the operating system (`false`, the default value).|
|"System.GC.Server"|true | false|Determines whether the application uses server garbage collection (`true`) or workstation garbage collection (`false`, the default value). For more information, see [Configuring garbage collection](../../standard/garbage-collection/fundamentals.md#configuring-garbage-collection).|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these supposed to be an exhaustive list of what's supported in runtimeconfig.json in 3.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @rpetrusha was trying to document all of them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, then if you do a search for "System.GC" in eeconfig.cpp, everything you see there should be documented.

@Maoni0
Copy link
Member

Maoni0 commented Oct 22, 2019

I started to look but had a question what the scope is; is this supposed to cover all that's supported in .net core 3.0? 'cause I see that there are only 3 System.GC configs in runtimeconfig.json.

CC @Andy-MS.

@Maoni0 Maoni0 mentioned this pull request Oct 31, 2019
Closed
@gewarren gewarren dismissed their stale review November 4, 2019 18:31

Changes requested from product unit.

@gewarren gewarren assigned gewarren and unassigned rpetrusha Nov 4, 2019
gewarren added a commit to gewarren/docs that referenced this pull request Nov 8, 2019
@gewarren
add in ron's change from pr dotnet#12959
37b73af
gewarren added a commit to gewarren/docs that referenced this pull request Nov 8, 2019
@gewarren
add in ron's changes from pr dotnet#12959
ffeeb1b
@rpetrusha rpetrusha requested a review from BillWagner as a code owner November 8, 2019 22:54
@gewarren gewarren changed the title Updated GC configuration information, added .NET Core config section Update .NET Framework GC config info Nov 9, 2019
@gewarren gewarren merged commit 70d6f3a into dotnet:master Nov 9, 2019
gewarren added a commit that referenced this pull request Nov 13, 2019
@gewarren
Note the default GC latency mode (#15760)
bb11d5c 
* fixes #9739

* add in ron's changes from pr #12959

* feedback from tom
Youssef1313 pushed a commit to Youssef1313/docs that referenced this pull request Nov 20, 2019
@gewarren @Youssef1313
Note the default GC latency mode (dotnet#15760)
d6722af 
* fixes dotnet#9739

* add in ron's changes from pr dotnet#12959

* feedback from tom
gewarren added a commit that referenced this pull request Nov 21, 2019
@gewarren
GC fundamentals clean up (#15761)
b3eb3c4 
* fixes #12783

* add in ron's change from pr #12959

* Update docs/standard/garbage-collection/fundamentals.md

Co-Authored-By: Next Turn <45985406+NextTurn@users.noreply.github.com>

* review feedback from maoni and bill

* remove config section; add link to new doc; acrolinx

* add links to specific config settings
@gewarren gewarren mentioned this pull request Dec 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahfalk noahfalk noahfalk left review comments

@jkotas jkotas jkotas left review comments

@mikem8361 mikem8361 mikem8361 left review comments

@Maoni0 Maoni0 Maoni0 left review comments

@mairaw mairaw mairaw left review comments

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT left review comments

@Youssef1313 Youssef1313 Youssef1313 requested changes

@davidwrighton davidwrighton davidwrighton approved these changes

@gewarren gewarren gewarren approved these changes

@BillWagner BillWagner Awaiting requested review from BillWagner

Assignees

@gewarren gewarren

Labels
dotnet-framework/svc waiting-on-feedback Waiting for feedback from SMEs before they can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document additional GC configuration settings