Skip to content

GC fundamentals clean up #15761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Nov 21, 2019
Merged

GC fundamentals clean up #15761

merged 23 commits into from
Nov 21, 2019

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Nov 8, 2019

Fixes #12783

  • Add a note that concurrent GC is for 3.5 and earlier and move this section down to bottom
  • Remove back to top anchors
  • Style improvements

@gewarren gewarren requested a review from BillWagner as a code owner November 8, 2019 01:50
@dotnet-bot dotnet-bot added this to the November 2019 milestone Nov 8, 2019
@gewarren gewarren requested a review from mairaw as a code owner November 8, 2019 20:40
gewarren added a commit to rpetrusha/docs that referenced this pull request Nov 8, 2019
@gewarren
remove changes that are taken care of by prs dotnet#15760 and dotnet#…
569d9cf 
…15761
gewarren pushed a commit that referenced this pull request Nov 9, 2019
@rpetrusha @gewarren
Update .NET Framework GC config info (#12959)
70d6f3a 
* Documented additional GC switches

* Updated TOC

* Update docs/core/runtime-config/envvars.md

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* Update docs/core/runtime-config/index.md

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* remove changes that are taken care of by prs #15760 and #15761

* add new elements to index file and parent element table; toc improvements
@mairaw
Copy link
Contributor

mairaw commented Nov 9, 2019

There are some merge conflicts here

@mairaw mairaw removed this from the November 2019 milestone Nov 9, 2019
@mairaw
Copy link
Contributor

mairaw commented Nov 12, 2019

There are still merge conflicts here. Do you want to take care of that before we start reviewing?

@mairaw mairaw requested a review from Maoni0 November 15, 2019 21:01
@BillWagner
Copy link
Member

BillWagner commented Nov 15, 2019 •
edited
Loading

@gewarren This really looks good. I reviewed it today, and I like it. I did have one question. I'd be ready to approve it, once you and @Maoni0 are happy with the content.

Let me know when you are ready for a final approval.

@Maoni0
Copy link
Member

Maoni0 commented Nov 16, 2019

  • A heap and a dedicated thread to perform garbage collection are provided for each CPU, and the heaps are collected at the same time. Each heap contains a small object heap and a large object heap, and all heaps can be accessed by user code. Objects on different heaps can refer to each other.

probably a good idea to introduce the SOH/LOH acronyms here

Refers to: docs/standard/garbage-collection/fundamentals.md:197 in 3251442. [](commit_id = 3251442, deletion_comment = False)

Maoni0
Maoni0 reviewed Nov 16, 2019
View reviewed changes
docs/standard/garbage-collection/fundamentals.md Outdated

![Concurrent Garbage Collection Threads](./media/gc-concurrent.png)

## Configure garbage collection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configure garbage collection [](start = 2, length = 29)

should this just point to the page that you are working on, @gewarren?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good idea. I added the link, which will be broken until that PR is merged.

@mairaw mairaw added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Nov 19, 2019
@mairaw
Copy link
Contributor

mairaw commented Nov 19, 2019

I've added a label to indicate this PR is waiting on the other one first.

@gewarren gewarren removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Nov 20, 2019
@gewarren
Copy link
Contributor Author

Close/reopen for new build.

@gewarren gewarren closed this Nov 21, 2019
@gewarren gewarren reopened this Nov 21, 2019
@gewarren
Copy link
Contributor Author

@BillWagner I'm ready for a final approval. Thanks much!

BillWagner
BillWagner approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really well organized, and a great article.

You can :shipit: when ready.

@gewarren
Copy link
Contributor Author

@BillWagner Thanks very much!

@gewarren gewarren merged commit b3eb3c4 into dotnet:master Nov 21, 2019
@gewarren gewarren deleted the concurrent-gc branch November 21, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maoni0 Maoni0 Maoni0 left review comments

@BillWagner BillWagner BillWagner approved these changes

@mairaw mairaw Awaiting requested review from mairaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

To improve performance ,disable concurrent GC
5 participants
@gewarren @mairaw @BillWagner @Maoni0 @dotnet-bot