-
Notifications
You must be signed in to change notification settings - Fork 6k
Run-time config knobs #16019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run-time config knobs #16019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some things to consider for consistency.
| **runtimeconfig.json** | `System.Net.Http.SocketsHttpHandler.Http2Support` | `false` - disabled<br/>`true` - enabled | .NET Core 3.0 | | ||
| **Environment variable** | `DOTNET_SYSTEM_NET_HTTP_SOCKETSHTTPHANDLER_HTTP2SUPPORT` | 0 - disabled<br/>1 - enabled | .NET Core 3.0 | | ||
|
||
## Sockets HTTP handler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are removing these settings for .NET 5. Can we update the docs for this?
cc @ManickaP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We aren't supposed to talk about future functionality in docs, so I don't think we need to mention it yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the right way to track updating the docs with this info once .NET 5 ships?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo comments. |
* updating links from fwlink to real link if exists (#15945) * updating links from fwlink to real link if exists * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * undoing linking change * Update docs/framework/whats-new/obsolete-types.md Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * updating aspnet links * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * [DocsArchive-1.0.19259.5](2019-09-22-20-26-07)Auto archive content (#14590) * [DocsArchive-1.0.19259.5](2019-09-22-20-26-07)Auto archive content * additional changes * Updates for the new dotnet/runtime repo (#15983) * Update system-text-json-overview.md * Update system-text-json-overview.md * Update system-text-json-overview.md * Update about.md * Update instructions for RHEL (#16050) * Update instructions for RHEL * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Update date * Fixes #11069 (#16058) * Fix typo in timespan format (#16071) * Replace Windows 7/8 tokens (#16074) * Replace Windows 7 tokens * Remove win7-md.md * Replace Windows 8 tokens * Remove win8-md.md * Replace Windows 8.1 tokens * Remove win81-md.md * add later versions (#16076) * add later versions * Apply suggestions from docs review Co-Authored-By: Genevieve Warren <gewarren@microsoft.com> * remove version from link text (#16077) * Spark: spark streaming article (#15842) * spark streaming article * make spark streaming a tutorial * Update docs/spark/tutorials/streaming.md Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> * update link * Update docs/spark/tutorials/streaming.md Co-Authored-By: Bill Wagner <wiwagn@microsoft.com> * update xrefs * fix xref * Update unit-testing-with-dotnet-test.md (#15954) * Update unit-testing-with-dotnet-test.md * Update unit-testing-with-dotnet-test.md * Update unit-testing-with-dotnet-test.md * Update unit-testing-with-dotnet-test.md * Apply suggestions from code review Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> * Apply suggestions from code review Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> * Update unit-testing-with-dotnet-test.md * Update unit-testing-with-dotnet-test.md * Update docs/core/testing/unit-testing-with-dotnet-test.md Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com> * Run-time config knobs (#16019) * add settings to toc * add config files for various settings * add working with calendars changes * updating links from fwlink to real link if exists (#16065) * updating links from fwlink to real link if exists - contributes to #3391 * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * undoing samples fwlink * Update docs/framework/windows-workflow-foundation/how-to-host-multiple-versions-of-a-workflow-side-by-side.md Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * add a later version (#16080) * add a later version * more updates * Update docs/framework/debug-trace-profile/pinvokestackimbalance-mda.md Co-Authored-By: Genevieve Warren <gewarren@microsoft.com> * fix backtick escaping (#16056) * separate OS info (#16063) * Typo, add missing "s" (#16093)
* #15390 Remove links to outdated tutorials on string interpolation (#15401) * Update live with current master (#16095) * updating links from fwlink to real link if exists (#15945) * updating links from fwlink to real link if exists * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * undoing linking change * Update docs/framework/whats-new/obsolete-types.md Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * updating aspnet links * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * [DocsArchive-1.0.19259.5](2019-09-22-20-26-07)Auto archive content (#14590) * [DocsArchive-1.0.19259.5](2019-09-22-20-26-07)Auto archive content * additional changes * Updates for the new dotnet/runtime repo (#15983) * Update system-text-json-overview.md * Update system-text-json-overview.md * Update system-text-json-overview.md * Update about.md * Update instructions for RHEL (#16050) * Update instructions for RHEL * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Update date * Fixes #11069 (#16058) * Fix typo in timespan format (#16071) * Replace Windows 7/8 tokens (#16074) * Replace Windows 7 tokens * Remove win7-md.md * Replace Windows 8 tokens * Remove win8-md.md * Replace Windows 8.1 tokens * Remove win81-md.md * add later versions (#16076) * add later versions * Apply suggestions from docs review Co-Authored-By: Genevieve Warren <gewarren@microsoft.com> * remove version from link text (#16077) * Spark: spark streaming article (#15842) * spark streaming article * make spark streaming a tutorial * Update docs/spark/tutorials/streaming.md Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> * update link * Update docs/spark/tutorials/streaming.md Co-Authored-By: Bill Wagner <wiwagn@microsoft.com> * update xrefs * fix xref * Update unit-testing-with-dotnet-test.md (#15954) * Update unit-testing-with-dotnet-test.md * Update unit-testing-with-dotnet-test.md * Update unit-testing-with-dotnet-test.md * Update unit-testing-with-dotnet-test.md * Apply suggestions from code review Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> * Apply suggestions from code review Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> * Update unit-testing-with-dotnet-test.md * Update unit-testing-with-dotnet-test.md * Update docs/core/testing/unit-testing-with-dotnet-test.md Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com> * Run-time config knobs (#16019) * add settings to toc * add config files for various settings * add working with calendars changes * updating links from fwlink to real link if exists (#16065) * updating links from fwlink to real link if exists - contributes to #3391 * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * undoing samples fwlink * Update docs/framework/windows-workflow-foundation/how-to-host-multiple-versions-of-a-workflow-side-by-side.md Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * add a later version (#16080) * add a later version * more updates * Update docs/framework/debug-trace-profile/pinvokestackimbalance-mda.md Co-Authored-By: Genevieve Warren <gewarren@microsoft.com> * fix backtick escaping (#16056) * separate OS info (#16063) * Typo, add missing "s" (#16093) * update live with master (#17118) * fix last msdn blogs urls (#17089) * fix last msdn blogs urls * Remove locale * Remove period * Microservices guide general update to 3.1 (#16202) * Update authentication * Update Visual Studio 2017 references and images * Update references and some code snippets to 3.1 * Update references + code snippets to 3.1 * Update IHostedServices Section * Update value objects section * Apply suggestions from code review Co-Authored-By: Nish Anil <nish@microsoft.com> * Apply suggestions from code review Co-Authored-By: Nish Anil <nish@microsoft.com> * Apply further review comments * Fix Markdownlinter errors * Apply suggestions from code review Missed review comment Co-Authored-By: Nish Anil <nish@microsoft.com> * Fix image name * Update edit dates * Remove remnant temporary file * Update docs/architecture/microservices/multi-container-microservice-net-applications/implement-api-gateways-with-ocelot.md * Update docs/architecture/microservices/multi-container-microservice-net-applications/implement-api-gateways-with-ocelot.md * Replaced Important with Note * Update implement-api-gateways-with-ocelot.md * Fix blank lines * Update position * Apply suggestions from code review (to be continued...) Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Apply suggestions from code review Ready with suggestions, manual changes are coming next. Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Apply manual changes from reviews. * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Add more review comments * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Remove locale from link * Update docs/architecture/microservices/implement-resilient-applications/monitor-app-health.md Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Add review comments * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Add review comment from local repo. Co-authored-by: Nish Anil <nish@microsoft.com> Co-authored-by: Maira Wenzel <mairaw@microsoft.com> * Update Azure table offerings for application Architecture (#17011) * Update table - Update recommendations - Convert it to markdown for accessibility * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Apply review comments. Co-authored-by: Maira Wenzel <mairaw@microsoft.com> * Document warnaserror:nullable option (#17094) * Modulo operator -> remainder operator (#17102) * update some CLI ref commands for 3.1 (#17101) * update CLI ref commands for 3.1 * fix * Add link to tutorial of using pattern matching (#17108) * Remove the note about the struct breaking change from the conceptual docs (#17114) * Fix the note about the struct breaking change * Removed the note Co-authored-by: Maira Wenzel <mairaw@microsoft.com> Co-authored-by: Miguel Veloso <mvelosop@gmail.com> Co-authored-by: Nish Anil <nish@microsoft.com> Co-authored-by: Julien Couvreur <jcouv@users.noreply.github.com> Co-authored-by: Petr Kulikov <petr.kulikov@gmail.com> Co-authored-by: Roman Marusyk <Marusyk@users.noreply.github.com> * Add f1_keywords to keyword-reference (#17624) These keywords are listed in archived F# keywords topic (https://docs-archive.visualstudio.com/docs-archive-project/_git/VS2013-docs-archive-pr?path=%2Fvs-2013%2Fdd233249(v%3Dvs.120).md&%3Bversion=GBlive&%3B_a=contents). Docs.F1 needs these keywords added in the fresh content to return a fresh result for those F1 keywords. * Revert "Install for Ubuntu 20.04 (#17869)" (#18089) (#18092) This reverts commit 7eb84cf. * Fix default checksum algorithm Fixes #18925 Co-authored-by: Maira Wenzel <mairaw@microsoft.com> Co-authored-by: Ron Petrusha <ronpet@microsoft.com> Co-authored-by: Pablo Marcano <pablo1012@outlook.com> Co-authored-by: Andy De George <2672110+Thraka@users.noreply.github.com> Co-authored-by: Genevieve Warren <gewarren@microsoft.com> Co-authored-by: Tom Dykstra <tdykstra@microsoft.com> Co-authored-by: Miguel Veloso <mvelosop@gmail.com> Co-authored-by: Nish Anil <nish@microsoft.com> Co-authored-by: Julien Couvreur <jcouv@users.noreply.github.com> Co-authored-by: Petr Kulikov <petr.kulikov@gmail.com> Co-authored-by: Roman Marusyk <Marusyk@users.noreply.github.com> Co-authored-by: Nat Kershaw (MSFT) <nakersha@microsoft.com> Co-authored-by: CXWTool Service Account <cxwtool@microsoft.com> Co-authored-by: junshi356 <40595015+junshi356@users.noreply.github.com> Co-authored-by: David Pine <david.pine@microsoft.com>
Add configuration knobs for .NET Core through runtimeconfig.json or environment variables.
Fixes #15850
Preview links:
Compilation
Debugging and profiling
Globalization
Networking
Threading