Merge latest main into release/stable #4355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[main] Update dependencies from dotnet/runtime
[main] Update dependencies from dotnet/aspnetcore
[main] Update dependencies from dotnet/aspnetcore
[main] Update dependencies from dotnet/runtime
This pull request updates the following dependencies [marker]: <> (Begin:cb58fe07-ae24-4e73-0e84-08d8e40a189f) ## From https://github.com/microsoft/clrmd - **Subscription**: cb58fe07-ae24-4e73-0e84-08d8e40a189f - **Build**: 20230928.1 - **Date Produced**: September 28, 2023 10:49:03 PM UTC - **Commit**: 10e87fb192d41e22d5fd0fd54f02ed011726e991 - **Branch**: refs/heads/main [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.Diagnostics.Runtime**: [from 3.0.447501 to 3.0.447801][1] - **Microsoft.Diagnostics.Runtime.Utilities**: [from 3.0.447501 to 3.0.447801][1] [1]: microsoft/clrmd@6d7c5a7...10e87fb [DependencyUpdate]: <> (End) [marker]: <> (End:cb58fe07-ae24-4e73-0e84-08d8e40a189f) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
[main] Update dependencies from dotnet/aspnetcore
…nd when using the Windows thread pool (dotnet#4160) Uses the properties exposed in microsoft/clrmd#1175 to show relevant Windows thread pool information if it's enabled --------- Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
This pull request updates the following dependencies [marker]: <> (Begin:cb58fe07-ae24-4e73-0e84-08d8e40a189f) ## From https://github.com/microsoft/clrmd - **Subscription**: cb58fe07-ae24-4e73-0e84-08d8e40a189f - **Build**: 20230929.1 - **Date Produced**: September 29, 2023 3:41:14 PM UTC - **Commit**: 547545a301475a7cfd23ce8c2f6e24eddf55d83e - **Branch**: refs/heads/main [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.Diagnostics.Runtime**: [from 3.0.447801 to 3.0.447901][1] - **Microsoft.Diagnostics.Runtime.Utilities**: [from 3.0.447801 to 3.0.447901][1] [1]: microsoft/clrmd@10e87fb...547545a [DependencyUpdate]: <> (End) [marker]: <> (End:cb58fe07-ae24-4e73-0e84-08d8e40a189f) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
[main] Update dependencies from dotnet/aspnetcore
* Add support for -v none, suppressing all logging making dotnet-dsrouter quiet. * Add support for --info option for new iOS/Android preconfig commands, outputs details on how to configure app and diagnostic tools to connect to current running dsrouter instance. * Improve error handling when failing to find or execute adb binary. * Specify and validate supported verbose logging levels.
[main] Update dependencies from microsoft/clrmd
[main] Update dependencies from dotnet/aspnetcore
[main] Update dependencies from dotnet/installer - Update Versions.props
…es (dotnet#4279) This is needed to reduce the conflicts/dependencies on loadable extensions.
Reads the JSON crash info from the triage buffer in the NativeAOT runtime. Adds a ICrashInfoService and SpecialDiagInfo helper class.
dotnet#4289) [main] Update dependencies from dotnet/source-build-reference-packages
[main] Update dependencies from dotnet/aspnetcore
This pull request updates the following dependencies [marker]: <> (Begin:e4bfb556-e13c-47f6-eb5a-08d8e4d5099b) ## From https://github.com/dotnet/runtime - **Subscription**: e4bfb556-e13c-47f6-eb5a-08d8e4d5099b - **Build**: 20231002.11 - **Date Produced**: October 3, 2023 11:06:54 AM UTC - **Commit**: ef6283ac0a14c78d9e9fef4841545099bd7ad12b - **Branch**: refs/heads/release/8.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.NETCore.App.Runtime.win-x64**: [from 8.0.0-rtm.23478.17 to 8.0.0-rtm.23502.11][1] - **VS.Redist.Common.NetCore.SharedFramework.x64.8.0**: [from 8.0.0-rtm.23478.17 to 8.0.0-rtm.23502.11][1] [1]: dotnet/runtime@b20f704...ef6283a [DependencyUpdate]: <> (End) [marker]: <> (End:e4bfb556-e13c-47f6-eb5a-08d8e4d5099b) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
[main] Update dependencies from dotnet/aspnetcore
This pull request updates the following dependencies [marker]: <> (Begin:e4bfb556-e13c-47f6-eb5a-08d8e4d5099b) ## From https://github.com/dotnet/runtime - **Subscription**: e4bfb556-e13c-47f6-eb5a-08d8e4d5099b - **Build**: 20231003.15 - **Date Produced**: October 4, 2023 5:51:18 AM UTC - **Commit**: a84f8ffbf5d597b8a91e893a1f413466de017a68 - **Branch**: refs/heads/release/8.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.NETCore.App.Runtime.win-x64**: [from 8.0.0-rtm.23502.11 to 8.0.0-rtm.23503.15][1] - **VS.Redist.Common.NetCore.SharedFramework.x64.8.0**: [from 8.0.0-rtm.23502.11 to 8.0.0-rtm.23503.15][1] [1]: dotnet/runtime@ef6283a...a84f8ff [DependencyUpdate]: <> (End) [marker]: <> (End:e4bfb556-e13c-47f6-eb5a-08d8e4d5099b) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…port (dotnet#4285) Add extension load testing that includes duplicate command names. Add internal CommandGroup class to CommandService dotnet-dump analyze -c/--command will exit on any parsing errors or exceptions in the command command help not displayed on parsing errors/invalid options Add INIT_API_CHECK_MANAGED native SOS command macro Rename clrmodules command to assemblies and keep clrmodules as an alias Support static HelpInvoke/FilterInvoke methods Add command service testing Better command service help interface. Returns help text instead of printing it on the console directly. ICommandService.DisplayHelp() => GetHelpText(). Better help sorting. Fix some SOS scripts Return error code for command line option errors in native SOS Load next to executing assembly first when hosted under desktop Framework Test using "clrthreads" instead of "Threads" Replace testing "u" with "clru" Add more general command filter mechanism. Add FilterType property to Command attribute. Remove OS filter command flags. NativeAddressHelper service work Move Windows managed command stubs to separate file Add SOS.Hosting services to SOS.Extensions for better native command help. This requires the special ManagedOnlyCommandFilter service to prevent recursion of the C++ commands. On Windows this recursion is from "C++ command" -> "checking if managed version" -> "executing the command in SOS.Hosting" -> "C++ command". Help is now uniform across managed/native, alphabetized and filtered by the current runtime.
This pull request updates the following dependencies [marker]: <> (Begin:cb58fe07-ae24-4e73-0e84-08d8e40a189f) ## From https://github.com/microsoft/clrmd - **Subscription**: cb58fe07-ae24-4e73-0e84-08d8e40a189f - **Build**: 20231004.2 - **Date Produced**: October 4, 2023 10:57:18 PM UTC - **Commit**: 10828baeeb7a144414259d9c00a9923c2fcb61e7 - **Branch**: refs/heads/main [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.Diagnostics.Runtime**: [from 3.0.450101 to 3.1.450402][3] - **Microsoft.Diagnostics.Runtime.Utilities**: [from 3.0.450101 to 3.1.450402][3] [3]: microsoft/clrmd@1c8f0f1...10828ba [DependencyUpdate]: <> (End) [marker]: <> (End:cb58fe07-ae24-4e73-0e84-08d8e40a189f) --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This pull request updates the following dependencies [marker]: <> (Begin:e4bfb556-e13c-47f6-eb5a-08d8e4d5099b) ## From https://github.com/dotnet/runtime - **Subscription**: e4bfb556-e13c-47f6-eb5a-08d8e4d5099b - **Build**: 20231004.8 - **Date Produced**: October 4, 2023 10:14:40 PM UTC - **Commit**: 22b8a5665f5725a2c7bb09cfbe88f2cdc9847c1a - **Branch**: refs/heads/release/8.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.NETCore.App.Runtime.win-x64**: [from 8.0.0-rtm.23503.15 to 8.0.0-rtm.23504.8][1] - **VS.Redist.Common.NetCore.SharedFramework.x64.8.0**: [from 8.0.0-rtm.23503.15 to 8.0.0-rtm.23504.8][1] [1]: dotnet/runtime@a84f8ff...22b8a56 [DependencyUpdate]: <> (End) [marker]: <> (End:e4bfb556-e13c-47f6-eb5a-08d8e4d5099b) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This pull request updates the following dependencies [marker]: <> (Begin:319094f3-ed78-47c4-53e7-08d8e409d87d) ## From https://github.com/dotnet/aspnetcore - **Subscription**: 319094f3-ed78-47c4-53e7-08d8e409d87d - **Build**: 20231004.12 - **Date Produced**: October 4, 2023 8:08:32 PM UTC - **Commit**: 91314b6bde6e9823f848fb37100aea5df4e44c99 - **Branch**: refs/heads/release/8.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.AspNetCore.App.Ref**: [from 8.0.0-rtm.23503.8 to 8.0.0-rtm.23504.12][1] - **Microsoft.AspNetCore.App.Ref.Internal**: [from 8.0.0-rtm.23503.8 to 8.0.0-rtm.23504.12][1] [1]: dotnet/aspnetcore@2d2f880...91314b6 [DependencyUpdate]: <> (End) [marker]: <> (End:319094f3-ed78-47c4-53e7-08d8e409d87d) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
[main] Update dependencies from dotnet/aspnetcore
This pull request updates the following dependencies [marker]: <> (Begin:e4bfb556-e13c-47f6-eb5a-08d8e4d5099b) ## From https://github.com/dotnet/runtime - **Subscription**: e4bfb556-e13c-47f6-eb5a-08d8e4d5099b - **Build**: 20231006.12 - **Date Produced**: October 7, 2023 3:40:26 AM UTC - **Commit**: b17a34c818bd5e01fdb9827fea64727a5fc51025 - **Branch**: refs/heads/release/8.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.NETCore.App.Runtime.win-x64**: [from 8.0.0-rtm.23504.8 to 8.0.0-rtm.23506.12][1] - **VS.Redist.Common.NetCore.SharedFramework.x64.8.0**: [from 8.0.0-rtm.23504.8 to 8.0.0-rtm.23506.12][1] [1]: dotnet/runtime@22b8a56...b17a34c [DependencyUpdate]: <> (End) [marker]: <> (End:e4bfb556-e13c-47f6-eb5a-08d8e4d5099b) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This pull request updates the following dependencies [marker]: <> (Begin:319094f3-ed78-47c4-53e7-08d8e409d87d) ## From https://github.com/dotnet/aspnetcore - **Subscription**: 319094f3-ed78-47c4-53e7-08d8e409d87d - **Build**: 20231006.5 - **Date Produced**: October 7, 2023 1:42:18 AM UTC - **Commit**: 6bd37340c54e3b9690102886afca6198a461cb3e - **Branch**: refs/heads/release/8.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.AspNetCore.App.Ref**: [from 8.0.0-rtm.23505.1 to 8.0.0-rtm.23506.5][1] - **Microsoft.AspNetCore.App.Ref.Internal**: [from 8.0.0-rtm.23505.1 to 8.0.0-rtm.23506.5][1] [1]: dotnet/aspnetcore@51f80c7...6bd3734 [DependencyUpdate]: <> (End) [marker]: <> (End:319094f3-ed78-47c4-53e7-08d8e409d87d) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
[main] Update dependencies from dotnet/installer - Update Versions.props
[main] Update dependencies from dotnet/symstore
[main] Update dependencies from dotnet/runtime
dotnet#4336) [main] Update dependencies from dotnet/source-build-reference-packages
This pull request updates the following dependencies [marker]: <> (Begin:319094f3-ed78-47c4-53e7-08d8e409d87d) ## From https://github.com/dotnet/aspnetcore - **Subscription**: 319094f3-ed78-47c4-53e7-08d8e409d87d - **Build**: 20231016.6 - **Date Produced**: October 16, 2023 8:00:36 PM UTC - **Commit**: 02bdf7077b8d96039bd39d6189a1abdefc41e65e - **Branch**: refs/heads/release/8.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.AspNetCore.App.Ref**: [from 8.0.0-rtm.23514.1 to 8.0.0-rtm.23516.6][1] - **Microsoft.AspNetCore.App.Ref.Internal**: [from 8.0.0-rtm.23514.1 to 8.0.0-rtm.23516.6][1] [1]: dotnet/aspnetcore@faf594a...02bdf70 [DependencyUpdate]: <> (End) [marker]: <> (End:319094f3-ed78-47c4-53e7-08d8e409d87d) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Small bug fix on the dotnet-monitor side from the unification work - we previously didn't create a payload for `BeginInstrumentReporting`, and thus only checked that a payload wasn't an error or the end of a counter. The code now leverages the newly-added `IsValuePublishedEvent` from the unification to only apply to the correct payloads.
[main] Update dependencies from microsoft/clrmd
[main] Update dependencies from dotnet/runtime
This pull request updates the following dependencies [marker]: <> (Begin:319094f3-ed78-47c4-53e7-08d8e409d87d) ## From https://github.com/dotnet/aspnetcore - **Subscription**: 319094f3-ed78-47c4-53e7-08d8e409d87d - **Build**: 20231017.6 - **Date Produced**: October 17, 2023 5:56:46 PM UTC - **Commit**: e3aba084cde27f8e718b188e3e9f7239e63d5816 - **Branch**: refs/heads/release/8.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.AspNetCore.App.Ref**: [from 8.0.0-rtm.23516.6 to 8.0.0-rtm.23517.6][1] - **Microsoft.AspNetCore.App.Ref.Internal**: [from 8.0.0-rtm.23516.6 to 8.0.0-rtm.23517.6][1] [1]: dotnet/aspnetcore@02bdf70...e3aba08 [DependencyUpdate]: <> (End) [marker]: <> (End:319094f3-ed78-47c4-53e7-08d8e409d87d) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This pull request updates the following dependencies [marker]: <> (Begin:e4bfb556-e13c-47f6-eb5a-08d8e4d5099b) ## From https://github.com/dotnet/runtime - **Subscription**: e4bfb556-e13c-47f6-eb5a-08d8e4d5099b - **Build**: 20231018.26 - **Date Produced**: October 19, 2023 7:20:11 AM UTC - **Commit**: c6e7ebdcb1b99c72990ae9f5ff95a75d5bb0f3ce - **Branch**: refs/heads/release/8.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.NETCore.App.Runtime.win-x64**: [from 8.0.0-rtm.23517.16 to 8.0.0-rtm.23518.26][1] - **VS.Redist.Common.NetCore.SharedFramework.x64.8.0**: [from 8.0.0-rtm.23517.16 to 8.0.0-rtm.23518.26][1] [1]: dotnet/runtime@6f7af55...c6e7ebd [DependencyUpdate]: <> (End) [marker]: <> (End:e4bfb556-e13c-47f6-eb5a-08d8e4d5099b) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This pull request updates the following dependencies [marker]: <> (Begin:319094f3-ed78-47c4-53e7-08d8e409d87d) ## From https://github.com/dotnet/aspnetcore - **Subscription**: 319094f3-ed78-47c4-53e7-08d8e409d87d - **Build**: 20231018.6 - **Date Produced**: October 18, 2023 11:05:03 PM UTC - **Commit**: 198857c8a2211931739e6e08facfbab52f8dd023 - **Branch**: refs/heads/release/8.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.AspNetCore.App.Ref**: [from 8.0.0-rtm.23517.6 to 8.0.0-rtm.23518.6][1] - **Microsoft.AspNetCore.App.Ref.Internal**: [from 8.0.0-rtm.23517.6 to 8.0.0-rtm.23518.6][1] [1]: dotnet/aspnetcore@e3aba08...198857c [DependencyUpdate]: <> (End) [marker]: <> (End:319094f3-ed78-47c4-53e7-08d8e409d87d) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…4342) The use of automatic port forwarding on Android device used the same port as local and remote, that should be possible, but turns out there is some issue with `adb` around that configuration when running against a physical Android device (works when using port forwarding/reverse against Android emulator). This PR change the port defaults and align to Xamarin Android documentation as well as using different ports for local and remove when using -`tcps` or -`tcpc` arguments together with `--forward-port android`. When running using the "Android" connect profile, `dotnet-dsrouter android` we will default to 9001 as local/host and 9000 as remote/device port. When running with -`tcps` or -`tcpc` we will use passed port as local/host port and then set the remote/device port to local/host port - 1 in call to `adb reverse|forward`. Fixes dotnet#4337
This PR reworks how log scopes are reconstructed. The current implementation has a several issues that results in it only working in single-threaded contexts. Once multiple threads are involved, scopes will be incorrectly associated to log messages in addition to scopes being deleted early while they are still active. I've described how the new approach works in the source code so it doesn't get lost after this PR is merged. I've also left a comment with a visual representation of edge cases with concurrent traces. /cc @dotnet/dotnet-monitor --------- Co-authored-by: Wiktor Kopec <wiktork@microsoft.com>
Retire duplicate documentation by redirecting to docs that will be updated. fixes dotnet#515 --------- Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
dotnet#4347) [main] Update dependencies from dotnet/source-build-reference-packages
This pull request updates the following dependencies [marker]: <> (Begin:319094f3-ed78-47c4-53e7-08d8e409d87d) ## From https://github.com/dotnet/aspnetcore - **Subscription**: 319094f3-ed78-47c4-53e7-08d8e409d87d - **Build**: 20231019.14 - **Date Produced**: October 20, 2023 5:00:06 AM UTC - **Commit**: e4ba445101d9bdae24baa6b332d19a11ac8922be - **Branch**: refs/heads/release/8.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.AspNetCore.App.Ref**: [from 8.0.0-rtm.23518.6 to 8.0.0-rtm.23519.14][1] - **Microsoft.AspNetCore.App.Ref.Internal**: [from 8.0.0-rtm.23518.6 to 8.0.0-rtm.23519.14][1] [1]: dotnet/aspnetcore@198857c...e4ba445 [DependencyUpdate]: <> (End) [marker]: <> (End:319094f3-ed78-47c4-53e7-08d8e409d87d) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
[main] Update dependencies from dotnet/runtime
[main] Update dependencies from dotnet/aspnetcore
[main] Update dependencies from dotnet/arcade
[main] Update dependencies from dotnet/installer - Update Versions.props
… really a ulong member. (dotnet#4354) The ModuleLoadUnload events ModuleID is typed as a uint64 in the EventPipe manifest and emitted as a uint64 in the event payload. However, the parsing logic in ModuleLoadUnloadTraceDataevent in trace event: https://github.com/microsoft/perfview/blob/a6c87911fe1aef8f59c9ce54aa4e16a1be6db91e/src/TraceEvent/Parsers/ClrEtwAll.cs.base#L4963 handles it as a long. Android devices running arm64 can use pointer tagging meaning that high bits can be set in 64-bit addresses and since module id is a memory address, it will be returned as a negative long from ModuleLoadUnload event and since all diagnostic tooling is build with overflow checking enabled by default, casting it to a ulong will trigger and overflow exception when high bit is set. Fix is to do an unchecked cast in this case since the value should be threated as a ulong in first place. Fixes dotnet#4348.
…tnet#4345) Session id is a uint64 in runtime as well as specified as a uint64 in IPC protocol, https://github.com/dotnet/diagnostics/blob/main/documentation/design-docs/ipc-protocol.md#returns-as-an-ipc-message-payload. EventPipeSession.cs however handled it as a long instead of an ulong, currently that doesn't affect release builds since it doesn't do much with the id except passing it back to stop the session, but in debug builds there is an assert that validates that session id > 0. On Android physical devices it is not uncommon to get code and memory allocated at high addresses, including having the high order bit set and when that happens, EventPipeSession.cs will see a negative session id and assert on debug builds. Fix adjust session id as ulong inline with IPC protocol, it also makes sure keyword serialized when starting a session is handled according to IPC specification, but only when serialized into the payload, it will still be typed as long inside EventPipeProvider since it is a public property.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the major version to 8.