Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/aspnetcore
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: faf594a066
Choose a base ref
...
head repository: dotnet/aspnetcore
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 02bdf7077b
Choose a head ref
  • 3 commits
  • 5 files changed
  • 3 contributors

Commits on Oct 14, 2023

  1. Update dependencies from https://github.com/dotnet/runtime build 2023…

    …1013.17
    
    Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Composition , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
     From Version 8.0.0-rtm.23511.16 -> To Version 8.0.0-rtm.23513.17
    dotnet-maestro[bot] committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    ee28b04 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Merge pull request #51371 from dotnet/darc-release/8.0-b15342cd-5221-…

    …45b4-ab1d-0fb02b271791
    
    [release/8.0] Update dependencies from dotnet/runtime
    eerhardt authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    949aa42 View commit details
    Browse the repository at this point in the history
  2. Fix form actions for apps deployed behind reverse proxy (#51403)

    # Fix form actions for apps deployed behind reverse proxy
    
    Makes forms work for apps deployed behind a reverse proxy.
    
    ## Description
    
    Apps deployed behind a reverse proxy (e.g., container apps) should not try to emit absolute URLs by default because the scheme/hostname/port may differ from what is reachable from the outside world. The fix is to emit root-relative URLs.
    
    Fixes #51380
    
    ## Customer Impact
    
    Without this fix, apps deployed behind a reverse proxy (e.g., in ACA) would not support form posts.
    
    ## Regression?
    
    - [ ] Yes
    - [x] No
    
    No because this only affects SSR forms, which is a new feature in .NET 8.
    
    ## Risk
    
    - [ ] High
    - [ ] Medium
    - [x] Low
    
    Low because this is only a change to how we generate the URL for a form's `action` attribute. Previously we used an absolute URL, but now we use a root-relative one. There is no other runtime change. Everything else in this PR is extra tests and updating existing tests.
    
    ## Verification
    
    - [x] Manual (required)
    - [x] Automated
    
    ## Packaging changes reviewed?
    
    - [ ] Yes
    - [ ] No
    - [x] N/A
    SteveSandersonMS authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    02bdf70 View commit details
    Browse the repository at this point in the history
Loading