Update SOS to show the relevant information for the !ThreadPool command when using the Windows thread pool

[eduardo-vp]

Uses the properties exposed in microsoft/clrmd#1175 to show relevant Windows thread pool information if it's enabled

[kouvel]

Thanks!

[mikem8361]

You have a lot of build errors in the PR builds before this is ready for review.

[kouvel]

This change is dependent on microsoft/clrmd#1175, so I guess a version update of some sort is necessary to pick up those changes.

[mikem8361]

@leculver we may have a little chicken or egg thing going here. The clrmd DARC update that probably contains this fix has build problems.

[mikem8361]

@eduardo-vp you merged an older version of main that doesn't contain the clrmd update. You need to fetch the latest main and rebase/merge that.

[eduardo-vp]

I believe I did pull from the latest main which brought version 3.0.447801 of Microsoft.Diagnostics.Runtime. I updated that to use version 3.0.447901 in eng/Versions.props, I'm trying to fix the issues by updating it in eng/Version.Details.xml as well

[mikem8361]

Sorry, I was confused by the build failure. It isn't anything to do with your threadpool changes on either side. It is do to a method being obsoleted and the diagnostics repo turns those warnings into errors:

/mnt/vss/_work/1/s/src/Microsoft.Diagnostics.ExtensionCommands/ClrMDHelper.cs(998,47): error CS0618: 'ClrObject.ClrObject(ulong, ClrType?)' is obsolete: 'Use ClrHeap.GetObject instead.' [/mnt/vss/_work/1/s/src/Microsoft.Diagnostics.ExtensionCommands/Microsoft.Diagnostics.ExtensionCommands.csproj]
/mnt/vss/_work/1/s/src/Microsoft.Diagnostics.ExtensionCommands/ClrMDHelper.cs(1118,33): error CS0618: 'ClrObject.ClrObject(ulong, ClrType?)' is obsolete: 'Use ClrHeap.GetObject instead.' [/mnt/vss/_work/1/s/src/Microsoft.Diagnostics.ExtensionCommands/Microsoft.Diagnostics.ExtensionCommands.csproj]
  Microsoft.Diagnostics.Repl -> /mnt/vss/_work/1/s/artifacts/bin/Microsoft.Diagnostics.Repl/Release/netstandard2.0/Microsoft.Diagnostics.Repl.dll

[ghost]

Hello @mikem8361!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this

From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.