This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Removing the System.Numerics.Vectors pkgproj #37301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Apr 30, 2019
jkotas
reviewed
Apr 30, 2019
tannergooding
commented
Apr 30, 2019
ericstj
reviewed
Apr 30, 2019
Member
|
Looks like CI was failing because it was depending on a netfx build of this assembly. Maybe we should just stop testing this library on desktop. If you still want test on desktop you need to restore the old package via https://github.com/dotnet/corefx/blob/master/external/binplacePackages/binplacePackages.depproj, but do so only for netfx as it will cause source build issues. |
Member
Author
ericstj
approved these changes
Apr 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion thread here: #37291 (comment)
CC. @jkotas, @CarolEidt, @terrajobst, @danmosemsft, @GrabYourPitchforks
Also CC. @ericstj to review the various changes. I expect I may have removed too much 😄