This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Mirror changes from dotnet/coreclr,corert #37314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may have to wait for decision on this one #37291 as the failure seems similar |
Member
|
Just waiting on #37301 to be merged. |
Member
|
@Anipik - both seem to be merged, is there anything else blocking this? |
krwq
force-pushed
the
mirror-merge-10166303
branch
from
7997436 to
ef81aaa
Compare
src/Common/src/CoreLib/System/Diagnostics/Tracing/TraceLogging/SimpleTypeInfos.cs
Outdated
Show resolved
Hide resolved
…e. (#23827) Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
* Nullable: System.Diagnostics.Tracing * apply feedback * fix one more comment Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
System.Type, System.Reflection nullability Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
* Nullable: Comparers, Dictionary and Friends * Add object constraint to Dictionary * Fix warning from new compiler and annotating dictionary * PR Feedback Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
krwq
force-pushed
the
mirror-merge-10166303
branch
from
c7105a7 to
8bcf3b8
Compare
| <GenFacadesIgnoreBuildAndRevisionMismatch>true</GenFacadesIgnoreBuildAndRevisionMismatch> | ||
|
|
||
| <!-- Warnings --> | ||
| <NoWarn>$(NoWarn);BCL0020</NoWarn> <!-- TODO: Remove BCL0020 once https://github.com/dotnet/arcade/pull/2158 is consumed. --> |
Member
There was a problem hiding this comment.
@stephentoub, this looks like it has likely been consumed by now.
Member
There was a problem hiding this comment.
Thanks for the reminder. I'll take care of it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains mirrored changes from dotnet/coreclr,corert
Please REBASE this PR when merging
cc @tannergooding @krwq @marek-safar @buyaa-n @safern