Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOJIRA] - If request protocol doesn't start with "HTTP" - http logging middleware responds with an error indicating the request protocol is invalid. #58781

fix: fixing grpc issue

2f90c24
Select commit
Loading
Failed to load commit list.
Azure Pipelines / aspnetcore-ci (Build Build: Windows x64/x86/arm64) failed Nov 4, 2024 in 14m 47s

Build Build: Windows x64/x86/arm64 failed

Annotations

Check failure on line 74 in src\Middleware\HttpLogging\src\HttpLoggingMiddleware.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-ci (Build Build: Windows x64/x86/arm64)

src\Middleware\HttpLogging\src\HttpLoggingMiddleware.cs#L74

src\Middleware\HttpLogging\src\HttpLoggingMiddleware.cs(74,13): error CS4032: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'await' operator can only be used within an async method. Consider marking this method with the 'async' modifier and changing its return type to 'Task<Task>'.

Check failure on line 51 in src\Middleware\HttpLogging\src\HttpLoggingMiddleware.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-ci (Build Build: Windows x64/x86/arm64)

src\Middleware\HttpLogging\src\HttpLoggingMiddleware.cs#L51

src\Middleware\HttpLogging\src\HttpLoggingMiddleware.cs(51,13): error CA1310: (NETCORE_ENGINEERING_TELEMETRY=Build) The behavior of 'string.StartsWith(string)' could vary based on the current user's locale settings. Replace this call in 'Microsoft.AspNetCore.HttpLogging.HttpLoggingMiddleware.Invoke(Microsoft.AspNetCore.Http.HttpContext)' with a call to 'string.StartsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)