Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOJIRA] - If request protocol doesn't start with "HTTP" - http logging middleware responds with an error indicating the request protocol is invalid. #58781

fix: fixing grpc issue

2f90c24
Select commit
Loading
Failed to load commit list.
Azure Pipelines / aspnetcore-ci (Build Source-Build (Managed)) failed Nov 4, 2024 in 5m 2s

Build Source-Build (Managed) failed

Annotations

Check failure on line 74 in artifacts/sb/src/src/Middleware/HttpLogging/src/HttpLoggingMiddleware.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-ci (Build Source-Build (Managed))

artifacts/sb/src/src/Middleware/HttpLogging/src/HttpLoggingMiddleware.cs#L74

artifacts/sb/src/src/Middleware/HttpLogging/src/HttpLoggingMiddleware.cs(74,13): error CS4032: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'await' operator can only be used within an async method. Consider marking this method with the 'async' modifier and changing its return type to 'Task<Task>'.

Check failure on line 51 in artifacts/sb/src/src/Middleware/HttpLogging/src/HttpLoggingMiddleware.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-ci (Build Source-Build (Managed))

artifacts/sb/src/src/Middleware/HttpLogging/src/HttpLoggingMiddleware.cs#L51

artifacts/sb/src/src/Middleware/HttpLogging/src/HttpLoggingMiddleware.cs(51,13): error CA1310: (NETCORE_ENGINEERING_TELEMETRY=Build) The behavior of 'string.StartsWith(string)' could vary based on the current user's locale settings. Replace this call in 'Microsoft.AspNetCore.HttpLogging.HttpLoggingMiddleware.Invoke(Microsoft.AspNetCore.Http.HttpContext)' with a call to 'string.StartsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)

Check failure on line 122 in .packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24551.1/tools/SourceBuild/SourceBuildArcadeBuild.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-ci (Build Source-Build (Managed))

.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24551.1/tools/SourceBuild/SourceBuildArcadeBuild.targets#L122

.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24551.1/tools/SourceBuild/SourceBuildArcadeBuild.targets(122,5): error MSB3073: The command "/__w/1/s/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:false /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=true /__w/1/s/.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24551.1/tools/Build.proj -p:RepoRoot=/__w/1/s/ /p:SourceBuildNonPortable= /p:DotNetBuildSourceOnly=true /p:DotNetBuildRepo=true /p:AssetManifestFileName=SourceBuild_Managed.xml -p:BuildNodeJSUnlessSourcebuild=true -p:BuildManaged=true -p:Restore=true -p:Build=true -p:Pack=true -p:Publish=true -p:Test=false -p:TargetArchitecture=x64 -p:TargetOsName=linux -p:Configuration=Release /bl:/__w/1/s/artifacts/log/Release/Build.binlog -logger:/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24551.1/tools/net9.0/Microsoft.DotNet.ArcadeLogging.dll  /p:DotNetBuildInnerRepo=true /p:DotNetBuildSourceOnly=true /p:RepoRoot="/__w/1/s/artifacts/sb/src/" /p:ArtifactsDir="/__w/1/s/artifacts/sb/src/artifacts/" /bl:"/__w/1/s/artifacts/sb/src/artifacts/log/Release/source-inner-build.binlog" /p:ContinuousIntegrationBuild=true /p:SourceBuildOutputDir="/__w/1/s/artifacts/sb/" /p:FullAssemblySigningSupported=false /p:DotNetPublishUsingPipelines=true /p:GitHubRepositoryName=aspnetcore" exited with code 1.