Removes support for PHP 5.x - #756
Conversation
|
@railto I think that the tested HHVM version needs tweaking. Please check the @travis-ci docs for that. |
|
And this work should start on the ORM and ODM side (otherwise they would not be able to require using new features) |
Brings in line with other package
|
|
||
| matrix: | ||
| allow_failures: | ||
| - php: hhvm |
There was a problem hiding this comment.
This is not a solution: check if a newer HHVM version is available - HHVM now support PHP7 stuff.
There was a problem hiding this comment.
Apologies, was bringing it in line with the other repos, will read up on how to force a version of HHVM as don't use it much myself at present.
| matrix: | ||
| matrix: | ||
| fast_finish: true | ||
| include: |
There was a problem hiding this comment.
This brings in the current version of HHVM, 3.17, however is still throwing the same error with
This package requires php ^7.0 but your HHVM version does not satisfy that requirement.
This error is also happening on other repos like the primary doctrine2 repo per this test - https://travis-ci.org/doctrine/doctrine2/jobs/188191005
Not sure what else I can do with this as HHVM 3.17 is not reporting to be PHP 7.x compatible per composer.
There was a problem hiding this comment.
@fredemmott can you eventually give us some insight on this?
There was a problem hiding this comment.
@railto on doctrine/orm#6288 I've managed to get the test suite running (but HHVM fails badly in terms of PHP compatibility that I gave up 😭).
What I've learned:
distshould be defined on the root level- we must set
hhvm.php7.all=1ANDhhvm.php7.scalar_types=0otherwise it doesn't work properly (HHVM simply enables strict mode for all files)
|
Closing as I do not have the ability to get this to work with HHVM tests |
|
Reopening: still needs to happen, even if you don't work on the PR yourself. |
|
I tried this using |
|
Handled in #785. |
|
Closing in favour of #785 |
8 participants
Removes support for PHP 5.x from composer.json and .travis.yml