-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropped PHP 5.x and 7.0 support - minimum of PHP 7.1 requirement #785
Conversation
.travis.yml
Outdated
@@ -20,7 +19,8 @@ matrix: | |||
env: PHPSTAN=1 | |||
|
|||
before_script: | |||
- composer --prefer-source install | |||
- if [[ $TRAVIS_PHP_VERSION = hhvm ]]; then composer --ignore-platform-reqs --prefer-source install; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--ignore-platform-reqs
is not acceptable here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine, I tried. 😊 Damn I hate HHVM for this versioning hell... When switched to php7 mode (hhvm --php -d hhvm.php7.all=true
), it works, but it's messy...
3b1332c
to
a83d9bd
Compare
Okay, HHVM will just not work in PHP 7 mode at all... It crashes Composer entirely in all versions (Symfony Finder specifically). |
See facebook/hhvm#7198 (comment) and composer/composer#6230 - bug in HHVM itself. |
Hey, I am curious whether support for HHVM is actually worth the effort? Perhaps add it as an allowed failure until the Facebook team resolves the issue? |
Maybe, but it's not up to me to decide. |
Well, according Saldaek in the issue you have provided, there's less people using HHVM and Composer, than PHP 5.3 (~0.4%). If I may be so bold, I would suggest sidelining (if not dropping altogether) support for it, since it only slows down development progress without being actually used by any substantial number of people. I know, it is not your call, but maybe someone else in the Doctrine team will consider this. |
I think @szymach's observation makes it clear: supporting HHVM is not worth it, and won't be worth it any soon due to the amount of effort needed to do it, while a lot of its PHP5 compatibility issues remain unpatched (and aren't in the project's focus either, as it seems). We can drop HHVM if we do an announcement, since we did indeed guarantee compatibility (see http://www.doctrine-project.org/2013/12/23/our-hhvm-roadmap.html ) |
@Majkl578 7.1 |
Roger, PR updated. |
👍 |
Supersedes and fixes #756.