Fix HHVM build (again) - #6288
Closed
lcobucci wants to merge 2 commits into
Closed
Conversation
We were expecting a return value for all methods but on doctrine/common@6a56df9 we changed some methods to be void and of course that affected the ORM.
lcobucci
force-pushed
the
fix-hhvm-version
branch
from
February 12, 2017 20:00
ccd2439 to
0800213
Compare
lcobucci
force-pushed
the
fix-hhvm-version
branch
from
February 12, 2017 20:07
0800213 to
f98496c
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.