Apply fixes on 5.x

[lcobucci]

Backporting these:

• Fix annotation groups usage #91
• Update the DealerDirect's composer installer dependency to v0.5.0 #93
• Add failing test to reproduce bug with associative arrays #103

I'm considering the dependency upgrade as a fix here since composer commands sometimes were failing and seems to be solved.

[Ocramius]

Since the tests for fixes changes, this would be a BC break for downstream projects using doctrine/coding-standard. I'm 👎 on this. Yes, it is a fix, but it will just lead to consumers to swear at us for having to change stuff.

Let's push it to the next major, please.

[lcobucci]

@Ocramius there's no BC break here (you can even see that build on 5.x is broken: https://travis-ci.org/doctrine/coding-standard/branches)....

The tests were wrong in the first place, consumers are already swearing due to wrong fixes of associative arrays.

[Ocramius]

due to wrong fixes of associative arrays.

I agree with the associative arrays scenario, not with the annotations one

[lcobucci]

@Ocramius check my last edit... that commit is only being applied because 5.x is currently broken on CI.

[Ocramius]

@lcobucci wait, 5.x is broken in CI? Did our dependencies break something again? :|

[lcobucci]

@Ocramius well, no. More or less. When #88 was introduced (using Slevomat CS v4.8.0), the sniff DocCommentSpacingSniff had bugs.

These bugs got fixed by Slevomat CS in v4.8.2 , v4.8.3, and v4.8.7, which lead me to send #91 to fix our failing build on master and then apply it here.

[lcobucci]

@Ocramius to give you more context: in #91 I tried to bring the discussion about reviewing the current groups (even suggested something) but decided initially to focus in fixing the tests, since they were not following the configuration we had.

[Ocramius]

Should we therefore start pinning upstream dependencies to patch releases? It seems to me that Slevomat CS is not stable enough, since these are indeed perceived as BC breaks downstream.

[lcobucci]

I think that it might create more issues for us... more releases to be made once we verified that their patches are reliable. Things look relatively stable so I'm not sure if we'd have much benefit too.

I've added 5.x to the Travis CI cron so we can detect issues and react to them, so I'd say we should be good after releasing this stuff here.

[Ocramius]

Fair enough then, but if we see more upstream misbehavior, we must lock upstream deps on our end, as they very much affect consumers.

[lcobucci]

@Ocramius agreed 👍