Add failing test to reproduce bug with associative arrays #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
requested changes
Jan 4, 2019
PHPCBF is adding two commas when fixing missing trailing commas on associative arrays.
This is already solved by SlevomatCodingStandard.Arrays.TrailingArrayComma.MissingTrailingComma. More info: slevomat/coding-standard#490
alcaeus
approved these changes
Jan 4, 2019
|
@Ocramius this should go to |
carusogabriel
approved these changes
Jan 4, 2019
ostrolucky
approved these changes
Jan 4, 2019
greg0ire
approved these changes
Jan 4, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some weird reason travis didn't run on #102, reopening it then...