Update the DealerDirect's composer installer dependency to v0.5.0 #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
previously approved these changes
Nov 1, 2018
|
Not sure what the build failure is about, @carusogabriel can you take a look? |
|
@alcaeus Looks like some BC was introduced by PHPCS or Slevomat. Gonna take a look ASAP. Edit: indeed, /cc @doctrine/coding-standard-approvers |
|
@alcaeus @carusogabriel the build failure is explained and fixed by #91 |
carusogabriel
suggested changes
Nov 1, 2018
carusogabriel
approved these changes
Nov 4, 2018
Ocramius
approved these changes
Nov 4, 2018
alcaeus
approved these changes
Nov 4, 2018
greg0ire
approved these changes
Nov 4, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dealerdirect/phpcodesniffer-composer-installer version 0.5.0 has been released which contains (among others) a fix for the plugin breaking the composer lifecycle.