Merged
Conversation
ndeloof
reviewed
Feb 6, 2020
compose/const.py
Outdated
| API_VERSIONS[COMPOSEFILE_V3_5]: '17.06.0', | ||
| API_VERSIONS[COMPOSEFILE_V3_6]: '18.02.0', | ||
| API_VERSIONS[COMPOSEFILE_V3_7]: '18.06.0', | ||
| API_VERSIONS[COMPOSEFILE_V3_8]: '19.03.0', |
Contributor
There was a problem hiding this comment.
as both COMPOSEFILE_V3_7 and COMPOSEFILE_V3_8 == '1.38' doesn't this override API_VERSIONS['1.28'] just being set to '18.06.0' ?
Contributor
Author
There was a problem hiding this comment.
Yep, but I guess this mapping is more for us to easily view the minimum version needed for each compose file.
ndeloof
reviewed
Feb 6, 2020
ndeloof
reviewed
Feb 6, 2020
compose/const.py
Outdated
| COMPOSEFILE_V3_5: '1.30', | ||
| COMPOSEFILE_V3_6: '1.36', | ||
| COMPOSEFILE_V3_7: '1.38', | ||
| COMPOSEFILE_V3_8: '1.40', |
Contributor
There was a problem hiding this comment.
Maybe I misunderstand this constant, but afaik 3.8 do not add any new field to require an API upgrade vs 3.7, does it?
Contributor
Author
There was a problem hiding this comment.
Yes, I set it back to 1.38. This should be the minimum API version we need for the v3.8 schema.
added 4 commits
February 7, 2020 13:50
- service scale bounded by 'max_replicas_per_node' field Signed-off-by: Anca Iordache <anca.iordache@docker.com>
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
596de14 to
02d8e9e
Compare
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
ndeloof
approved these changes
Feb 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add v3.8 schema support
Signed-off-by: Anca Iordache anca.iordache@docker.com
Resolves #6530