-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy over compose format 3.8 from docker/cli #6823
Conversation
816effe
to
611777e
Compare
Ping @chris-crone just in case. |
Also pinging @ulyssessouza, maybe this can get into a release sometime soon, seeing as 19.03 has already been released? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little comment regarding the tests
32cb757
to
8530fa4
Compare
We need to check the specs for this, and other versions; I tried this a while back, but noticed there's changes in this repository that are not upstream; if they're still needed, we need to make sure they're upstreamed, but also that they find their way into current versions of the spec See #6642 for some more details |
Would a better approach (in terms of mergeability of this PR) be to copy over the diffs from docker/cli beween config_schema_v3.7.json and config_schema_v3.8.json, rather than the entire config_schema_v3.8.json? |
Resolves docker#6530. Signed-off-by: Sune Keller <absukl@almbrand.dk>
Signed-off-by: Sune Keller <absukl@almbrand.dk>
Signed-off-by: Sune Keller <absukl@almbrand.dk>
8530fa4
to
5e587d5
Compare
Ping @thaJeztah about #6823 (comment) |
Well, I think there should be a single source of truth for these schemas; afaik, the version in I'm not familiar enough with the changes that were made in this repository to know if they are;
@ulyssessouza @chris-crone would one of you know? |
+1. Ideally we should pull what's in docker/cli out and put it into a separate repo
I do not but @shin- may know. Otherwise we can add a ticket to our backlog to find the diffs and investigate. |
@thaJeztah @chris-crone Any takers on this one? Docker Engine has had 3.8 format support since 19.03.0, and since 3.x is generally meant to be deployed on Swarm or Compose on Kubernetes, I would argue that fields and changes made in docker/cli should override those in docker/compose for 3.x formats. |
I would agree on this. We have an internal ticket tracking this, we just haven't prioritised it yet. I'll chat to our PM and see when we can fit it in. |
Any more progress with this? @ulyssessouza have you seen the update as per your request? |
Anyone have an update on this? Nearly been a year and itching to use a feature in the stack/compose files! |
Any updates here? Would be nice to be able to use the new features with 3.8 |
AFAIK this has been superseded by #7217 which is now merged. Thanks for the PR @sirlatrom! I'll close this. |
Resolves #6530.