[carry] Add support for template_driver in composefiles#1746
[carry] Add support for template_driver in composefiles#1746vdemeester merged 1 commit intodocker:masterfrom
template_driver in composefiles#1746Conversation
|
ping @silvin-lubecki @vdemeester PTAL |
Codecov Report
@@ Coverage Diff @@
## master #1746 +/- ##
==========================================
- Coverage 56.1% 56.09% -0.02%
==========================================
Files 306 306
Lines 21049 21057 +8
==========================================
+ Hits 11810 11812 +2
- Misses 8382 8386 +4
- Partials 857 859 +2 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1746 +/- ##
==========================================
- Coverage 56.1% 56.09% -0.02%
==========================================
Files 306 306
Lines 21049 21057 +8
==========================================
+ Hits 11810 11812 +2
- Misses 8382 8386 +4
- Partials 857 859 +2 |
vdemeester
left a comment
There was a problem hiding this comment.
Thanks 😍 LGTM 🦁
… but needs a rebase @thaJeztah
|
ah, saw that one coming 😅 - working on another PR, but I'll update after 👍 |
This maps the `--template-driver` flag on secret and config creation. Signed-off-by: Vincent Demeester <vincent@sbr.pm> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2b46921 to
7764101
Compare
|
rebased; regenerated cli/compose/schema/bindata.go |
|
Is the documentation at https://docs.docker.com/compose/compose-file generated from the source code here or is that a separate repo altogether? |
|
@masaeedu documentation there is not generated automatically, but from a Markdown file in https://github.com/docker/docker.github.io/blob/master/compose/compose-file/index.md |
|
@thaJeztah Would that repo be the right place to open an issue to add documentation concerning |
|
@masaeedu yes, that would be the right place. I think the reason it wasn't documented yet, was that docker-compose (standalone) did not yet have support for the 3.8 schema until docker/compose#7217 (which is in docker compose v1.25.5 and up: https://github.com/docker/compose/releases/tag/1.25.5. I see docker/docs#10273 added some of the changes, but didn't include all of them. Let me have a look at updating the docs |
|
opened docker/docs#10980 to add some basic information (probably could use some enhancement after that, but at least the fields are mentioned now) |
Carry of #1100 - rebased, and moved the option to schema 3.8
closes #1100
This maps the
--template-driverflag on secret and config creation.