compose-file: document additional changes in the 3.8 schema#10980
Merged
usha-mandya merged 1 commit intodocker:masterfrom Jun 12, 2020
Merged
compose-file: document additional changes in the 3.8 schema#10980usha-mandya merged 1 commit intodocker:masterfrom
usha-mandya merged 1 commit intodocker:masterfrom
Conversation
thaJeztah
added
the
area/compose
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
compose_3.8_additions
branch
from
d43f468 to
2c54c9f
Compare
thaJeztah
commented
Jun 10, 2020
| ``` | ||
|
|
||
| #### replicas | ||
| #### max_replicas_per_node |
Member
Author
There was a problem hiding this comment.
I swapped the order with replicas, because max_replicas_per_node is under placement (so not at the same level as replicas
|
Deploy preview for docsdocker ready! Built with commit d43f468 |
Member
Author
|
Deploy preview for docsdocker ready! Built with commit 2c54c9f |
usha-mandya
approved these changes
Jun 10, 2020
Member
usha-mandya
left a comment
usha-mandya
left a comment
There was a problem hiding this comment.
LGTM. Thank you @thaJeztah.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to docker/cli#896, docker/cli#1100, docker/cli#1746, docker/cli#1783, docker/cli#1410