This repository has been archived by the owner on Jul 1, 2020. It is now read-only.
Fixed Nexus 5x zxing barcode scanning issue(Nexus upside down issue) #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2017 10:17
dm77#280 dm77#313 The above code actually rotates only 90 degree.It works fine if device having normal camera orientation(Landscape).But for Nexus 5X device camera orientation is reverse landscape and it rotates 90 degree,so the preview data will be upside down. Normally when we use rectangle at center,it is very hard to identify this issue, because zxing scans barcode even if it is in reverse angle.When we move the rectangle points we can identify this issue. To fix this issue,I have rotated data based on camera orientation.Now it rotates 270 degree on Nexus device and 90 degree on normal orientation devices.
dm77#280 dm77#313 The above commented code actually rotates only 90 degree.It works fine if device having normal camera orientation(Landscape).But for Nexus 5X device camera orientation is reverse landscape and it rotates 90 degree,so the preview data will be upside down. Normally when we use rectangle at center,it is very hard to identify this issue, because zxing scans barcode even if it is in reverse angle.When we move the rectangle points we can identify this issue. To fix this issue,I have rotated data based on camera orientation.Now it rotates 270 degree on Nexus device and 90 degree on normal orientation devices.
This was referenced May 17, 2017
|
hi @rramprasad thank you so much for this pull request. Let me take a look and get back to you |
|
@dm77 How's the review going? |
|
It would be extremely good to get this pull request... |
|
Fixed in v1.9.5. Thank you @rramprasad for the pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I have fixed Nexus 5x barcode scanning issues
#280
#313
The existing data rotation code actually rotates only 90 degree.It works fine
if device having normal camera orientation(Landscape).But
for Nexus 5X device camera orientation is reverse landscape and
it rotates 90 degree,so the preview data will be upside down.
Normally when we use rectangle at center,it is very hard to identify this issue,
because zxing scans barcode even if it is in reverse angle.When we move the
rectangle points we can identify this issue.
To fix this issue,I have rotated data based on camera orientation.Now it rotates
270 degree on Nexus device and 90 degree on normal orientation devices.