Skip to content
This repository has been archived by the owner on Jul 1, 2020. It is now read-only.

Zxing handleResult not called in Nexus 5X-7.1.1 #280

Closed
rramprasad opened this issue Feb 24, 2017 · 5 comments
Closed

Zxing handleResult not called in Nexus 5X-7.1.1 #280

rramprasad opened this issue Feb 24, 2017 · 5 comments

Comments

@rramprasad
Copy link

rramprasad commented Feb 24, 2017

I am using barcode scanner latest version,

compile 'me.dm7.barcodescanner:zxing:1.9'

It works great on other devices except Nexus 5X(7.1.1) device.I doesn't called handleResult on the Fragment. I debug inside the ZXingScannerView.class and always I got com.google.zxing.NotFoundException on following line,

try {
       rawResult = mMultiFormatReader.decodeWithState(bitmap);
     } catch (ReaderException re) {
         // continue
         Log.d("ZxingScannerView","ReaderException ->"+re.toString());
}
@annanoell
Copy link

Hi @rramprasad , I'm facing the same issue. Could you fix it?
I'm using the ZXingScannerView inside a fragment, and the ResultHandler is never called when the ScannerView is inside a layout (the scanner might be half screen for my app). But it works if you place the code in the middle of the screen even if you cannot see the code.

Have you found a solution for this?

Thank you.

@rramprasad
Copy link
Author

@annanoell Refer my #284

rramprasad pushed a commit to rramprasad/barcodescanner that referenced this issue May 17, 2017
dm77#280
dm77#313
The above code actually rotates only 90 degree.It works fine
if device having normal camera orientation(Landscape).But
for Nexus 5X device camera orientation is reverse landscape and
it rotates 90 degree,so the preview data will be upside down.
Normally when we use rectangle at center,it is very hard to identify this issue,
because zxing scans barcode even if it is in reverse angle.When we move the
rectangle points we can identify this issue.
To fix this issue,I have rotated data based on camera orientation.Now it rotates
270 degree on Nexus device and 90 degree on normal orientation devices.
rramprasad pushed a commit to rramprasad/barcodescanner that referenced this issue May 17, 2017
dm77#280
dm77#313
The above commented code actually rotates only 90 degree.It works fine
if device having normal camera orientation(Landscape).But
for Nexus 5X device camera orientation is reverse landscape and
it rotates 90 degree,so the preview data will be upside down.
Normally when we use rectangle at center,it is very hard to identify this issue,
because zxing scans barcode even if it is in reverse angle.When we move the
rectangle points we can identify this issue.
To fix this issue,I have rotated data based on camera orientation.Now it rotates
270 degree on Nexus device and 90 degree on normal orientation devices.
@rramprasad
Copy link
Author

Fixed this issue,Refer #315

@rekhaagarwal
Copy link

@rramprasad @dm77 has the above issue fixed in latest version? facing the same issue on Nexus 5x on latest release 1.9.3. Can you please tell me when the fix will be released.

Thanks in advance. :)

@dm77
Copy link
Owner

dm77 commented Aug 19, 2017

Fixed in 1.9.8 finally. Thanks @rramprasad for the pull request

@dm77 dm77 closed this as completed Aug 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants