This repository has been archived by the owner on Jul 1, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Zxing handleResult not called in Nexus 5X-7.1.1 #280
Comments
Hi @rramprasad , I'm facing the same issue. Could you fix it? Have you found a solution for this? Thank you. |
@annanoell Refer my #284 |
rramprasad
pushed a commit
to rramprasad/barcodescanner
that referenced
this issue
May 17, 2017
dm77#280 dm77#313 The above code actually rotates only 90 degree.It works fine if device having normal camera orientation(Landscape).But for Nexus 5X device camera orientation is reverse landscape and it rotates 90 degree,so the preview data will be upside down. Normally when we use rectangle at center,it is very hard to identify this issue, because zxing scans barcode even if it is in reverse angle.When we move the rectangle points we can identify this issue. To fix this issue,I have rotated data based on camera orientation.Now it rotates 270 degree on Nexus device and 90 degree on normal orientation devices.
rramprasad
pushed a commit
to rramprasad/barcodescanner
that referenced
this issue
May 17, 2017
dm77#280 dm77#313 The above commented code actually rotates only 90 degree.It works fine if device having normal camera orientation(Landscape).But for Nexus 5X device camera orientation is reverse landscape and it rotates 90 degree,so the preview data will be upside down. Normally when we use rectangle at center,it is very hard to identify this issue, because zxing scans barcode even if it is in reverse angle.When we move the rectangle points we can identify this issue. To fix this issue,I have rotated data based on camera orientation.Now it rotates 270 degree on Nexus device and 90 degree on normal orientation devices.
Fixed this issue,Refer #315 |
@rramprasad @dm77 has the above issue fixed in latest version? facing the same issue on Nexus 5x on latest release 1.9.3. Can you please tell me when the fix will be released. Thanks in advance. :) |
Fixed in 1.9.8 finally. Thanks @rramprasad for the pull request |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I am using barcode scanner latest version,
It works great on other devices except Nexus 5X(7.1.1) device.I doesn't called handleResult on the Fragment. I debug inside the ZXingScannerView.class and always I got
com.google.zxing.NotFoundException
on following line,The text was updated successfully, but these errors were encountered: