Skip to content
This repository has been archived by the owner on Jul 1, 2020. It is now read-only.

ViewFinderView view updates,but scanning area not updated #313

Closed
rramprasad opened this issue May 15, 2017 · 1 comment
Closed

ViewFinderView view updates,but scanning area not updated #313

rramprasad opened this issue May 15, 2017 · 1 comment

Comments

@rramprasad
Copy link

ViewFinderView view updates,but scanning area not updated on Nexus 5X.I tried following to change my rectangle area on ViewFinder.java but it updates the view properly,but still scanning area same.It scans on old area only.How do I update scanning area properly?


public synchronized void updateFramingRect() {
        Point viewResolution = new Point(getWidth(), getHeight());
        int width;
        int height;
        int orientation = DisplayUtils.getScreenOrientation(getContext());

        if(mSquareViewFinder) {
            if(orientation != Configuration.ORIENTATION_PORTRAIT) {
                height = (int) (getHeight() * SQUARE_DIMENSION_RATIO);
                width = height;
            } else {
                width = (int) (getWidth() * SQUARE_DIMENSION_RATIO);
                height = width;
            }
        } else {
            if(orientation != Configuration.ORIENTATION_PORTRAIT) {
                height = (int) (getHeight() * LANDSCAPE_HEIGHT_RATIO);
                width = (int) (LANDSCAPE_WIDTH_HEIGHT_RATIO * height);
            } else {
                width = (int) (getWidth() * PORTRAIT_WIDTH_RATIO);
                height = (int) (PORTRAIT_WIDTH_HEIGHT_RATIO * width);
            }
        }

        if(width > getWidth()) {
            width = getWidth() - MIN_DIMENSION_DIFF;
        }

        if(height > getHeight()) {
            height = getHeight() - MIN_DIMENSION_DIFF;
        }

        int leftOffset = (viewResolution.x - width) / 2;
        int topOffset = ((viewResolution.y - height) / 2)-160; // *********updated here************
        mFramingRect = new Rect(leftOffset, topOffset, leftOffset + width, topOffset + height);
    }
rramprasad pushed a commit to rramprasad/barcodescanner that referenced this issue May 17, 2017
dm77#280
dm77#313
The above code actually rotates only 90 degree.It works fine
if device having normal camera orientation(Landscape).But
for Nexus 5X device camera orientation is reverse landscape and
it rotates 90 degree,so the preview data will be upside down.
Normally when we use rectangle at center,it is very hard to identify this issue,
because zxing scans barcode even if it is in reverse angle.When we move the
rectangle points we can identify this issue.
To fix this issue,I have rotated data based on camera orientation.Now it rotates
270 degree on Nexus device and 90 degree on normal orientation devices.
rramprasad pushed a commit to rramprasad/barcodescanner that referenced this issue May 17, 2017
dm77#280
dm77#313
The above commented code actually rotates only 90 degree.It works fine
if device having normal camera orientation(Landscape).But
for Nexus 5X device camera orientation is reverse landscape and
it rotates 90 degree,so the preview data will be upside down.
Normally when we use rectangle at center,it is very hard to identify this issue,
because zxing scans barcode even if it is in reverse angle.When we move the
rectangle points we can identify this issue.
To fix this issue,I have rotated data based on camera orientation.Now it rotates
270 degree on Nexus device and 90 degree on normal orientation devices.
@rramprasad
Copy link
Author

Fixed this issue,Refer #315

@dm77 dm77 closed this as completed Aug 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants