Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] Cherry-pick changes from master that are needed for dub to compile #8627

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Nov 17, 2022

Dub uses -preview=in to compile in its build.d script, but not in the dub.sdl (because Vibe.d wasn't DIP1000 compatible).
DMD v2.101.0 introduced a change that means -preview=in now disallows in on non-extern(D) / extern(C++) functions.
But since the fixes were done 3 days after the start of the v2.101 release, the dub CI is currently broken with latest.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @Geod24!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8627"

@Geod24 Geod24 merged commit 0301fd5 into dlang:master Nov 17, 2022
@Geod24 Geod24 deleted the make-dub-compile branch November 17, 2022 13:26
@ibuclaw
Copy link
Member

ibuclaw commented Nov 17, 2022

@Geod24

  1. Try not to cherry pick, commit to stable then merge to master to avoid conflicts and wasted time fixing them up.
  2. Title says stable, but you target master.

@Geod24
Copy link
Member Author

Geod24 commented Nov 17, 2022

Try not to cherry pick, commit to stable then merge to master to avoid conflicts and wasted time fixing them up.

git detect this quite well actually, at least from my experience when rebasing. What's your preferred approach ?

Title says stable, but you target master.

🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants