Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-instate accidentally reverted fixes on RefCounted #8599

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Oct 13, 2022

Those fixes were done in PR #8509 but PR #8368 accidentally reverted them.

Those fixes were done in PR dlang#8509 but PR dlang#8368 accidentally reverted them.
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @Geod24!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8599"

@Geod24 Geod24 requested a review from thewilsonator October 13, 2022 20:31
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems odd to me that pureFree on line 10134 is not actually marked pure

@thewilsonator thewilsonator merged commit 3c97810 into dlang:master Oct 13, 2022
@Geod24 Geod24 deleted the i-fixed-this-already branch October 14, 2022 09:25
@Geod24
Copy link
Member Author

Geod24 commented Oct 14, 2022

is not actually marked pure

It is within a block of attributes that includes pure.

Geod24 added a commit to Geod24/phobos that referenced this pull request Nov 17, 2022
Those fixes were done in PR dlang#8509 but PR dlang#8368 accidentally reverted them.
Geod24 added a commit to Geod24/phobos that referenced this pull request Nov 30, 2022
Those fixes were done in PR dlang#8509 but PR dlang#8368 accidentally reverted them.
@ibuclaw ibuclaw mentioned this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants