-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uses of 'in' on extern(C) functions #8509
Conversation
Thanks for your pull request, @Geod24! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8509" |
|
be3471c
to
e708b9e
Compare
Fixed |
It looks like dscanner cannot find the druntime related files. |
e708b9e
to
4573cca
Compare
Let's see if a rebase helps |
The problem is actually:
But the D-Scanner check seems to have its own issues |
4573cca
to
0295395
Compare
Style passed AND is readable 🎉 |
@RazvanN7 : Commit are atomic, don't squash them. |
Those fixes were done in PR dlang#8509 but PR dlang#8368 accidentally reverted them.
Those fixes were done in PR dlang#8509 but PR dlang#8368 accidentally reverted them.
Those fixes were done in PR dlang#8509 but PR dlang#8368 accidentally reverted them.
It is forbidden by DMD master.