Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of 'in' on extern(C) functions #8509

Merged
merged 3 commits into from
Jul 18, 2022

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Jul 15, 2022

It is forbidden by DMD master.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @Geod24!

Bugzilla references

Auto-close Bugzilla Severity Description
15862 critical Functions that return types with mutable indirections should be weakly pure, not strongly pure

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8509"

@thewilsonator
Copy link
Contributor

std/typecons.d(6653): Error: undefined identifier `pureGcRemoveRange`
std/typecons.d(6640): Error: undefined identifier `pureGcAddRange`
std/typecons.d(6653): Error: undefined identifier `pureGcRemoveRange`

@Geod24
Copy link
Member Author

Geod24 commented Jul 15, 2022

Fixed

@RazvanN7
Copy link
Collaborator

It looks like dscanner cannot find the druntime related files.

@Geod24
Copy link
Member Author

Geod24 commented Jul 18, 2022

Let's see if a rebase helps

@Geod24
Copy link
Member Author

Geod24 commented Jul 18, 2022

The problem is actually:

std/typecons.d(6602:20)[warn]: Local imports should specify the symbols being imported to avoid hiding local symbols.

But the D-Scanner check seems to have its own issues

@Geod24
Copy link
Member Author

Geod24 commented Jul 18, 2022

Style passed AND is readable 🎉

@Geod24
Copy link
Member Author

Geod24 commented Jul 18, 2022

@RazvanN7 : Commit are atomic, don't squash them.

@dlang-bot dlang-bot merged commit 258c64b into dlang:master Jul 18, 2022
@Geod24 Geod24 deleted the preview-in-extern branch July 18, 2022 15:58
Geod24 added a commit to Geod24/phobos that referenced this pull request Oct 13, 2022
Those fixes were done in PR dlang#8509 but PR dlang#8368 accidentally reverted them.
thewilsonator pushed a commit that referenced this pull request Oct 13, 2022
Those fixes were done in PR #8509 but PR #8368 accidentally reverted them.
Geod24 added a commit to Geod24/phobos that referenced this pull request Nov 17, 2022
Those fixes were done in PR dlang#8509 but PR dlang#8368 accidentally reverted them.
Geod24 added a commit to Geod24/phobos that referenced this pull request Nov 30, 2022
Those fixes were done in PR dlang#8509 but PR dlang#8368 accidentally reverted them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants