June beta hotfix 2 #3229
Closed
June beta hotfix 2 #3229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into dv/token_exceptions Resolved conflicts in ApiConnectId and ConnectSsoHelper.
… into dv/token_exceptions
Handling thrown token exceptions throughout the code and reporting to UI where appropriate.
…and recovery code continue button
… in app selector is selected.
…the relevant message for each scenario.
Fixing obsolete app selector code
… into dv/token_exceptions
…llapsing toolbar for the top part).
… into dv/token_exceptions
Changes to delivery progress text for each payment unit
remove secondry number handling
Otp related logging
Better error handling and retry mechanism for integrity token provider
PersonalID Lockout
Twilio fallback For Personal ID OTP
Contributor
Author
|
@damagatchi retest this please |
2 similar comments
Contributor
Author
|
@damagatchi retest this please |
Contributor
Author
|
@damagatchi retest this please |
|
Warning Rate limit exceeded@shubham1g5 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 17 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (100)
📝 WalkthroughWalkthroughThis update introduces a comprehensive set of features and improvements centered around the new "Connect" module, which includes job management, messaging, delivery tracking, and enhanced PersonalID/OTP flows within the CommCare Android application. Two new activities— Sequence Diagram(s)sequenceDiagram
participant User
participant ConnectActivity
participant ConnectManager
participant API/Backend
participant Messaging UI
participant CommCareFirebaseMessagingService
User->>ConnectActivity: Launch Connect feature
ConnectActivity->>ConnectManager: Initialize Connect session
ConnectActivity->>ConnectManager: Fetch user and active job
ConnectManager->>API/Backend: Fetch job opportunities, user info
API/Backend-->>ConnectManager: Job/user data
ConnectManager-->>ConnectActivity: Update UI with jobs
User->>ConnectActivity: Select job/messaging
ConnectActivity->>Messaging UI: Navigate to chat/channel list
User->>Messaging UI: Send message
Messaging UI->>ConnectManager: Store/send message
ConnectManager->>API/Backend: Send message to server
API/Backend-->>ConnectManager: Message delivery status
API/Backend-->>CommCareFirebaseMessagingService: Push notification (data payload)
CommCareFirebaseMessagingService->>ConnectManager: Process Connect action
CommCareFirebaseMessagingService->>Messaging UI: Broadcast update (if relevant)
CommCareFirebaseMessagingService->>User: Show notification (if not viewing messaging)
User->>ConnectActivity: Confirm payment via notification
CommCareFirebaseMessagingService->>PaymentAcknowledgeReceiver: Broadcast with payment info
PaymentAcknowledgeReceiver->>ConnectManager: Update payment status
ConnectManager->>API/Backend: Confirm payment
API/Backend-->>ConnectManager: Confirmation result
ConnectManager-->>User: Update UI/payment status
Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for building Hotix for Connect Beta adding twilio fallback