CCCT-890 #3005
CCCT-890 #3005
Conversation
…and recovery code continue button
📝 WalkthroughWalkthroughThe pull request modifies the control flow in several components. In the Sequence Diagram(s)sequenceDiagram
participant Caller
participant DatabaseUtil
participant ConnectManager
participant Database
Caller->>DatabaseUtil: Request app data/record
DatabaseUtil->>ConnectManager: isConnectIdConfigured()?
alt Connect ID Configured
ConnectManager-->>DatabaseUtil: true
DatabaseUtil->>Database: Fetch record
Database-->>DatabaseUtil: Record data
DatabaseUtil-->>Caller: Return record
else Not Configured
ConnectManager-->>DatabaseUtil: false
DatabaseUtil-->>Caller: Return null
end
sequenceDiagram
participant User
participant SignupFragment
participant ApiConnectId
participant ErrorTextView
User->>SignupFragment: Trigger phone check
SignupFragment->>ApiConnectId: checkPhoneAvailable(phoneNumber)
alt Success Response
ApiConnectId-->>SignupFragment: Success response
SignupFragment->>ErrorTextView: Set text "connect_phone_not_found" (recovery case)
else Failure Response
ApiConnectId-->>SignupFragment: Failure response (e.g., network/API error)
SignupFragment->>ErrorTextView: Set/adjust error text and visibility
end
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🧰 Additional context used🧠 Learnings (1)app/src/org/commcare/android/database/connect/models/ConnectJobRecord.java (1)🧬 Code Definitions (2)app/src/org/commcare/connect/database/ConnectAppDatabaseUtil.java (1)
app/src/org/commcare/connect/database/ConnectJobUtils.java (2)
🔇 Additional comments (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
shubham1g5
left a comment
shubham1g5
left a comment
There was a problem hiding this comment.
Can we add Jira links to issues this PR is trying to solve for in PR description.
app/src/org/commcare/android/database/connect/models/ConnectJobRecord.java
Outdated
Show resolved
Hide resolved
| case ConnectConstants.CONNECT_REGISTRATION_PRIMARY_PHONE, | ||
| ConnectConstants.CONNECT_REGISTRATION_CHANGE_PRIMARY_PHONE, | ||
| ConnectConstants.CONNECT_RECOVERY_PRIMARY_PHONE -> { | ||
| if (existingPrimary != null && existingPrimary.equals(phone)) { |
There was a problem hiding this comment.
what are we trying to solve here ? And why is primary check not required any more ?
There was a problem hiding this comment.
Because it was a issue we are getting existing no when we are changing the method from signup to recover we pass the no entered there so this condition willl never allow user to check phone no
|
@pm-dimagi How about we PR this to |
|
@shubham1g5 if we merge directly to master there are few files which are not present in the master code for now its in phase 2pr , we can take up these changes in phase 2pr |
|
@damagatchi retest this please |
Product Description
-bug fixes
expired opportunity bug fix
non connect user workflow
and continue button in recovery flow
https://dimagi.atlassian.net/browse/CCCT-890
https://dimagi.atlassian.net/browse/CCCT-900
Safety Assurance
Safety story
Describe:
In particular consider how existing data may be impacted by this change.
cross-request: dimagi/commcare-core#1455
Labels and Review