Otp related logging #3215
Otp related logging #3215
Conversation
| public void onFailure(OtpErrorType errorType, @Nullable String errorMessage) { | ||
| if (otpCallback == null) return; | ||
| logOtpVerification(false); | ||
| String userMessage = switch (errorType) { | ||
| case INVALID_CREDENTIAL -> getString(R.string.personalid_incorrect_otp); | ||
| case TOO_MANY_REQUESTS -> getString(R.string.personalid_too_many_otp_attempts); |
There was a problem hiding this comment.
@shubham1g5 can we log the Logger.exception from here only as it may be interesting to know the TOO_MANY_REQUESTS, VERIFICATION_FAILED and default error message?
There was a problem hiding this comment.
And its better to know how many user is facing TOO_MANY_REQUESTS error so that we can take actions in future accordingly
|
@shubham1g5 Also, should we log this failure ? Ideally, it should not fail once Firebase has validated OTP so will be interesting to know? |
shubham1g5
force-pushed
the
otpRelatedLogging
branch
from
43386a6 to
7686788
Compare
That handles result of HQ call to verify otp which can still fail due to netwrok errors which we are already logging as a soft log at the moment, so I don't think it will help further in context of the issues we are getting. |
Product Description
https://dimagi.atlassian.net/browse/CI-113
Technical Summary
Labels and Review