Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sound.cpp #10

Merged
2 commits merged into from
Dec 29, 2018
Merged

Update sound.cpp #10

2 commits merged into from
Dec 29, 2018

Conversation

Chance4us
Copy link
Contributor

great audio quality improvement from 8 to 16 bit format

@Chance4us
Update sound.cpp
5d0fa1a 
great audio quality improvement from 8 to 16 bit format
@Chance4us
Update sound.cpp
17286b8 
line 104 / Mix_OpenAudio / third parameter had to be reverted
@Chance4us
Copy link
Contributor Author

Why did the build failed?

@ghost
Copy link

ghost commented Dec 29, 2018

Hey chance4us tgank you for the pr

I will check in a few, it should work.

@ghost
Copy link

ghost commented Dec 29, 2018

Ok I checked it out. It appears to not have conflicts.

The only problem I have is that I think the channels are letting letting tracks go without music stopping being called. Talk to the wounded man and and while he is talking go down. The audio will continue in the dungeon.

It is a known issue that ending dialog doesn't stop soundfx .

ghost
ghost reviewed Dec 29, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will commit and fix the channel issue.

ghost
ghost approved these changes Dec 29, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will commit and fix the channel issue.

@ghost ghost merged commit 28d337a into diasurgical:master Dec 29, 2018
AJenbo pushed a commit that referenced this pull request Jan 20, 2019
@ApertureSecurity
Merge pull request #10 from Chance4us/master
8a783f5 
Update sound.cpp
@and31 and31 mentioned this pull request Jul 10, 2019
Closed
@pgielda pgielda mentioned this pull request Jul 25, 2019
Closed
@hamdyaea hamdyaea mentioned this pull request Oct 17, 2019
Closed
glebm added a commit to glebm/devilutionX that referenced this pull request Mar 23, 2021
@glebm
Fix memory leak in single-player difficulty selection
f7f1426 
Single-player difficulty selection was implemented in a very hacky way.

Documents what's going on there and fixes a memory leak.

Memory leaks that this fixes looked like this:

```
Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x7f435b789f17 in operator new(unsigned long) (/lib/x86_64-linux-gnu/libasan.so.6+0xb1f17)
    #1 0x5567766c62b8 in dvl::selgame_GameSelection_Select(int) ../SourceX/DiabloUI/selgame.cpp:163
    #2 0x5567766d8ee8 in dvl::selhero_Load_Select(int) ../SourceX/DiabloUI/selhero.cpp:464
    #3 0x5567766d6ed1 in dvl::selhero_List_Select(int) ../SourceX/DiabloUI/selhero.cpp:325
    #4 0x556776692683 in dvl::UiFocusNavigationSelect() ../SourceX/DiabloUI/diabloui.cpp:396
    #5 0x55677669158e in HandleMenuAction ../SourceX/DiabloUI/diabloui.cpp:223
    #6 0x5567766917b9 in dvl::UiFocusNavigation(SDL_Event*) ../SourceX/DiabloUI/diabloui.cpp:277
    #7 0x556776695dff in dvl::UiPollAndRender() ../SourceX/DiabloUI/diabloui.cpp:626
    #8 0x5567766d94ef in UiSelHeroDialog ../SourceX/DiabloUI/selhero.cpp:512
    diasurgical#9 0x5567766d997f in dvl::UiSelHeroSingDialog(int (*)(int (*)(dvl::_uiheroinfo*)), int (*)(dvl::_uiheroinfo*), int (*)(dvl::_uiheroinfo*), void (*)(unsigned int, dvl::_uidefaultstats*), int*, char (*) [16], int*) ../SourceX/DiabloUI/selhero.cpp:547
    diasurgical#10 0x556776a44f45 in mainmenu_select_hero_dialog ../Source/mainmenu.cpp:98
    diasurgical#11 0x5567765f9f15 in SNetInitializeProvider ../SourceX/storm/storm_net.cpp:102
    diasurgical#12 0x556776c996b9 in multi_init_single ../Source/multi.cpp:826
    diasurgical#13 0x556776c98b1e in NetInit ../Source/multi.cpp:770
    diasurgical#14 0x5567767d0c0b in StartGame ../Source/diablo.cpp:375
    diasurgical#15 0x556776a4493d in mainmenu_init_menu ../Source/mainmenu.cpp:45
    diasurgical#16 0x556776a44c05 in mainmenu_single_player ../Source/mainmenu.cpp:61
    diasurgical#17 0x556776a454a9 in mainmenu_loop ../Source/mainmenu.cpp:152
    diasurgical#18 0x5567767d2892 in DiabloMain ../Source/diablo.cpp:602
    diasurgical#19 0x5567766e3c69 in main ../SourceX/main.cpp:34
    diasurgical#20 0x7f435a69ecb1 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x28cb1)
```
AJenbo pushed a commit that referenced this pull request Mar 23, 2021
@glebm @AJenbo
Fix memory leak in single-player difficulty selection
7269ade 
Single-player difficulty selection was implemented in a very hacky way.

Documents what's going on there and fixes a memory leak.

Memory leaks that this fixes looked like this:

```
Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x7f435b789f17 in operator new(unsigned long) (/lib/x86_64-linux-gnu/libasan.so.6+0xb1f17)
    #1 0x5567766c62b8 in dvl::selgame_GameSelection_Select(int) ../SourceX/DiabloUI/selgame.cpp:163
    #2 0x5567766d8ee8 in dvl::selhero_Load_Select(int) ../SourceX/DiabloUI/selhero.cpp:464
    #3 0x5567766d6ed1 in dvl::selhero_List_Select(int) ../SourceX/DiabloUI/selhero.cpp:325
    #4 0x556776692683 in dvl::UiFocusNavigationSelect() ../SourceX/DiabloUI/diabloui.cpp:396
    #5 0x55677669158e in HandleMenuAction ../SourceX/DiabloUI/diabloui.cpp:223
    #6 0x5567766917b9 in dvl::UiFocusNavigation(SDL_Event*) ../SourceX/DiabloUI/diabloui.cpp:277
    #7 0x556776695dff in dvl::UiPollAndRender() ../SourceX/DiabloUI/diabloui.cpp:626
    #8 0x5567766d94ef in UiSelHeroDialog ../SourceX/DiabloUI/selhero.cpp:512
    #9 0x5567766d997f in dvl::UiSelHeroSingDialog(int (*)(int (*)(dvl::_uiheroinfo*)), int (*)(dvl::_uiheroinfo*), int (*)(dvl::_uiheroinfo*), void (*)(unsigned int, dvl::_uidefaultstats*), int*, char (*) [16], int*) ../SourceX/DiabloUI/selhero.cpp:547
    #10 0x556776a44f45 in mainmenu_select_hero_dialog ../Source/mainmenu.cpp:98
    #11 0x5567765f9f15 in SNetInitializeProvider ../SourceX/storm/storm_net.cpp:102
    #12 0x556776c996b9 in multi_init_single ../Source/multi.cpp:826
    #13 0x556776c98b1e in NetInit ../Source/multi.cpp:770
    #14 0x5567767d0c0b in StartGame ../Source/diablo.cpp:375
    #15 0x556776a4493d in mainmenu_init_menu ../Source/mainmenu.cpp:45
    #16 0x556776a44c05 in mainmenu_single_player ../Source/mainmenu.cpp:61
    #17 0x556776a454a9 in mainmenu_loop ../Source/mainmenu.cpp:152
    #18 0x5567767d2892 in DiabloMain ../Source/diablo.cpp:602
    #19 0x5567766e3c69 in main ../SourceX/main.cpp:34
    #20 0x7f435a69ecb1 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x28cb1)
```
@AJenbo AJenbo mentioned this pull request Apr 4, 2021
Closed
kphoenix137 pushed a commit to kphoenix137/devilutionX that referenced this pull request Sep 15, 2023
@wkdgmr
Merge pull request diasurgical#10 from wkdgmr/refactor_devx_15
1b226bb 
Refactor DevX 1.5 Release
kphoenix137 added a commit to kphoenix137/devilutionX that referenced this pull request Mar 27, 2024
@kphoenix137
Enforce specific play area regardless of screen resolution (diasurgic…
a5b20d9 
…al#10)

* Enforce play within restricted screen area

* Change radius to 15
kphoenix137 added a commit to kphoenix137/devilutionX that referenced this pull request Mar 31, 2024
@kphoenix137
Enforce specific play area regardless of screen resolution (diasurgic…
921342b 
…al#10)

* Enforce play within restricted screen area

* Change radius to 15
kphoenix137 added a commit to kphoenix137/devilutionX that referenced this pull request Apr 6, 2024
@kphoenix137
Enforce specific play area regardless of screen resolution (diasurgic…
5422e58 
…al#10)

* Enforce play within restricted screen area

* Change radius to 15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Chance4us