Assets up-scaling (future request) #3

baszczewski · 2018-10-03T08:12:13Z

Please support modern resolutions and post processing filters for up-scaling. This will allow to presents game in modern, but maybe little cartoonish way. I made some samples with Waifu2x filter:

ghost · 2018-10-13T18:37:38Z

I plan on adding this in.

It shouldn't be too hard either.

Thanks for issue.

ghost · 2018-12-28T05:57:37Z

You can now resize the window after game start

AJenbo · 2019-01-28T21:45:49Z

At the moment we have it using a virtual resolution so it's not locked to anything specific. Tee scaling is very basic though.

AJenbo · 2019-02-01T09:19:44Z

The game now runs in fullscreen (native desktop resolution) and uses bilinear scalling.

Waifu2x appears to not be perfomant enough to be used for post processing and processing the assets would require a rewrite of the render engine. hqx might be a more realistic route to go. Implementing it here should be fairly straight forward:
https://github.com/diasurgical/devilutionX/blob/master/Stub/dx.cpp#L83 though you would probably have to disable logical LogicalSize and handle scaling of coordinates manually.
https://github.com/diasurgical/devilutionX/blob/master/Stub/DiabloUI/sdlrender.cpp#L203

https://github.com/diasurgical/devilutionX/blob/master/Stub/DiabloUI/sdlrender.cpp#L405

sheepo99 · 2019-03-21T00:02:12Z

I have a question. Will advanced features such as HQ resolutions and other advanced features be supported by the DevilutionX build, or will they be exclusive to the future Devilution Plus Plus package?

AJenbo · 2019-03-21T01:23:51Z

I have a question. Will advanced features such as HQ resolutions and other advanced features be supported by the DevilutionX build, or will they be exclusive to the future Devilution Plus Plus package?

The groundworks are being laid, the very first step of making the graphics more configurable is basically ready #44. The render is being cleaned up (this is also a huge step toward 64bit support), this will give us the opportunity for making it hardware accelerated and resolution independent. So it may take a bit of time, but it is on its way.

AJenbo · 2019-03-23T14:04:28Z

Adding Waifu2x asssets depends on #46

Co-Authored-By: qndel <stefan551@o2.pl>

ivan89el · 2019-07-10T10:39:42Z

@baszczewski Tried topaz ai gigapixel turned out even more cute:

ghost · 2019-07-10T11:05:45Z

@ivan89el This issue is closed.

I like though the Russian in this. How much of the game is translated into Russian? Can we talk about this in our discord?

ivan89el · 2019-07-10T12:34:22Z

@ApertureSecurity The exe translation was done in hex and the old (1998) translated MPQ resources were used.

AJenbo · 2019-07-19T12:35:38Z

This one was pointed out on the GOG forums:
https://github.com/atheros/xbrzscale

qndel · 2019-07-19T12:44:15Z

Yeah but the thing is none of these are fast enough to be applied in realtime and modifying a screenshot is not a big deal

AJenbo · 2019-07-21T15:54:15Z

@qndel we could implement this as part of the loading routine, of cause that we rewrite the render to support upscaled tile, but that's on the road map anyway.

BF3000 · 2019-07-29T04:25:41Z

What can I say, there is more than enough scaling algorithms to do the job.
Bilinear,Bicubic, Lanczos, Blackman, Spline.
Something super heavy, like Nnedi3 or Waifu2x can be used to upscale sprites during level loading, but not for realtime rendering.

Update sdl1_wrapper.h

Merge upstream

dcworldwide · 2019-11-23T11:44:55Z

Interesting to note, ESRGAN project results are promising.

https://github.com/xinntao/ESRGAN
https://www.youtube.com/watch?v=zpwG2uNWhiQ
https://www.youtube.com/watch?v=FsoyC9j9MV0

Single-player difficulty selection was implemented in a very hacky way. Documents what's going on there and fixes a memory leak. Memory leaks that this fixes looked like this: ``` Direct leak of 64 byte(s) in 1 object(s) allocated from: #0 0x7f435b789f17 in operator new(unsigned long) (/lib/x86_64-linux-gnu/libasan.so.6+0xb1f17) #1 0x5567766c62b8 in dvl::selgame_GameSelection_Select(int) ../SourceX/DiabloUI/selgame.cpp:163 #2 0x5567766d8ee8 in dvl::selhero_Load_Select(int) ../SourceX/DiabloUI/selhero.cpp:464 #3 0x5567766d6ed1 in dvl::selhero_List_Select(int) ../SourceX/DiabloUI/selhero.cpp:325 #4 0x556776692683 in dvl::UiFocusNavigationSelect() ../SourceX/DiabloUI/diabloui.cpp:396 #5 0x55677669158e in HandleMenuAction ../SourceX/DiabloUI/diabloui.cpp:223 #6 0x5567766917b9 in dvl::UiFocusNavigation(SDL_Event*) ../SourceX/DiabloUI/diabloui.cpp:277 #7 0x556776695dff in dvl::UiPollAndRender() ../SourceX/DiabloUI/diabloui.cpp:626 #8 0x5567766d94ef in UiSelHeroDialog ../SourceX/DiabloUI/selhero.cpp:512 #9 0x5567766d997f in dvl::UiSelHeroSingDialog(int (*)(int (*)(dvl::_uiheroinfo*)), int (*)(dvl::_uiheroinfo*), int (*)(dvl::_uiheroinfo*), void (*)(unsigned int, dvl::_uidefaultstats*), int*, char (*) [16], int*) ../SourceX/DiabloUI/selhero.cpp:547 #10 0x556776a44f45 in mainmenu_select_hero_dialog ../Source/mainmenu.cpp:98 #11 0x5567765f9f15 in SNetInitializeProvider ../SourceX/storm/storm_net.cpp:102 #12 0x556776c996b9 in multi_init_single ../Source/multi.cpp:826 #13 0x556776c98b1e in NetInit ../Source/multi.cpp:770 #14 0x5567767d0c0b in StartGame ../Source/diablo.cpp:375 #15 0x556776a4493d in mainmenu_init_menu ../Source/mainmenu.cpp:45 #16 0x556776a44c05 in mainmenu_single_player ../Source/mainmenu.cpp:61 #17 0x556776a454a9 in mainmenu_loop ../Source/mainmenu.cpp:152 #18 0x5567767d2892 in DiabloMain ../Source/diablo.cpp:602 #19 0x5567766e3c69 in main ../SourceX/main.cpp:34 #20 0x7f435a69ecb1 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x28cb1) ```

dcworldwide · 2023-07-18T08:04:10Z

5 years on since op.... Has the technology's scalability improved enough to make this feasible?

F9 - ready, F10 - pause, F11 - play

AJenbo added the enhancement New feature or request label Mar 23, 2019

AJenbo added a commit that referenced this issue Mar 24, 2019

MI_LArrow bin exact suggestion #3

8abc0f4

Co-Authored-By: qndel <stefan551@o2.pl>

AJenbo mentioned this issue Jul 7, 2019

XBRZ scale #159

Closed

and31 mentioned this issue Jul 10, 2019

Diablo can not read required data #145

Closed

pgielda mentioned this issue Jul 25, 2019

Crash in DRLG_L1Shadows when entering Level 2 #209

Closed

AJenbo pushed a commit that referenced this issue Sep 26, 2019

Merge pull request #3 from nonarkitten/patch-4

4fe4ad1

Update sdl1_wrapper.h

AJenbo pushed a commit that referenced this issue Sep 26, 2019

Merge pull request #3 from diasurgical/master

490091d

Merge upstream

hamdyaea mentioned this issue Oct 17, 2019

Error at launch on Manjaro #368

Closed

AJenbo mentioned this issue Oct 22, 2019

Refactor OpenDingux build scripts #372

Merged

AJenbo mentioned this issue Nov 23, 2019

AI upscale textures #491

Closed

cosemansbert mentioned this issue Feb 28, 2020

Fails to start with runtime error: division by zero #644

Closed

AJenbo mentioned this issue Apr 4, 2021

heap-buffer-overflow when loading monk graphics #1361

Closed

FitzRoyX mentioned this issue May 15, 2021

Use cast animation in town #1980

Merged

StephenCWills mentioned this issue Aug 13, 2021

Fix uninitialized variable exception raised in Visual Studio debugger #2597

Merged

StephenCWills mentioned this issue Sep 22, 2021

Unicode font rendering #2904

Merged

ikonomov mentioned this issue Apr 15, 2022

Crackling sound with 1.2.0 and 1.4.0 #1390

Closed

sectune mentioned this issue Jan 14, 2023

miyoo_mini: Update OnionOS directory layout to match version 4. Brocky/devilutionX#2

Open

ikonomov mentioned this issue Oct 6, 2023

Update arenas #2 #6381

Open

tukkek pushed a commit to tukkek/turn-based-diablo-1 that referenced this issue Oct 16, 2024

Merge pull request diasurgical#3 from Songoo7/multiplayerReadyCommand

2c36855

F9 - ready, F10 - pause, F11 - play

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Assets up-scaling (future request) #3

Assets up-scaling (future request) #3

baszczewski commented Oct 3, 2018

ghost commented Oct 13, 2018

ghost commented Dec 28, 2018

AJenbo commented Jan 28, 2019

AJenbo commented Feb 1, 2019

sheepo99 commented Mar 21, 2019

AJenbo commented Mar 21, 2019 •

edited

Loading

AJenbo commented Mar 23, 2019 •

edited

Loading

ivan89el commented Jul 10, 2019

ghost commented Jul 10, 2019

ivan89el commented Jul 10, 2019

AJenbo commented Jul 19, 2019 •

edited

Loading

qndel commented Jul 19, 2019

AJenbo commented Jul 21, 2019

BF3000 commented Jul 29, 2019 •

edited

Loading

dcworldwide commented Nov 23, 2019

dcworldwide commented Jul 18, 2023

Assets up-scaling (future request) #3

Assets up-scaling (future request) #3

Comments

baszczewski commented Oct 3, 2018

ghost commented Oct 13, 2018

ghost commented Dec 28, 2018

AJenbo commented Jan 28, 2019

AJenbo commented Feb 1, 2019

sheepo99 commented Mar 21, 2019

AJenbo commented Mar 21, 2019 • edited Loading

AJenbo commented Mar 23, 2019 • edited Loading

ivan89el commented Jul 10, 2019

ghost commented Jul 10, 2019

ivan89el commented Jul 10, 2019

AJenbo commented Jul 19, 2019 • edited Loading

qndel commented Jul 19, 2019

AJenbo commented Jul 21, 2019

BF3000 commented Jul 29, 2019 • edited Loading

dcworldwide commented Nov 23, 2019

dcworldwide commented Jul 18, 2023

AJenbo commented Mar 21, 2019 •

edited

Loading

AJenbo commented Mar 23, 2019 •

edited

Loading

AJenbo commented Jul 19, 2019 •

edited

Loading

BF3000 commented Jul 29, 2019 •

edited

Loading