Repository navigation
chore(node): update Node.js version in Dockerfile and config.json - #6431
Merged
Merged
Conversation
1 task
yhabib
changed the title
yhabib
marked this pull request as ready for review
February 17, 2025 06:37
yhabib
changed the title
dskloetd
reviewed
Feb 17, 2025
dskloetd
approved these changes
Feb 17, 2025
1 task
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
# Motivation Following up on #6431, we aim to establish a single source of truth for the node version in the project. To remain consistent with other versions, we will use the one defined in `config.json`. Note: Some GitHub actions currently use `.nvmrc` to determine the node version. These will be changed in a follow-up PR. # Changes - Removed `NODE_VERSION` from the `Dockerfile` as it was not used. - Added a script to populate `.nvmrc` from `config.json` and exposed it as an npm script. - Removes `.nvmrc` from tracked files since it can now be generated locally. - Updated the `README` with local development instructions and information about `.nvmrc`. # Tests - GitHub actions should run as before. # Todos - [ ] Add entry to changelog (if necessary). Not necessary
1 task
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
# Motivation The project currently depends on Node 18. Some [jobs](https://github.com/dfinity/nns-dapp/actions/runs/15440734632/job/43458326957?pr=6920) in the CI are failing because the default Node version being installed is v20. We want to enforce the Node version defined in config.json #6431. # Changes - Define node version for e2e CI job. # Tests - Pipeline should be green. # Todos - [ ] Add entry to changelog (if necessary). Not necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We have a version mismatch of Node between our
dockerfileandconfig.json. Node 16 has not been supported for some time. This PR updates both the Dockerfile and config to the same version we use for development.Additionally, we could upgrade to the latest patch, which addresses some security vulnerabilities (v18.20.6) but this is not done in this PR.
Note: Version 18.20 addressed a "breaking change" introduced in v18 regarding how
Datemanages the space between the time andAM/PM. This adjustment was made following the update to the standard.Changes
dockerfileandconfig.jsonto18.20.5Tests
Todos
Not necessary