Repository navigation
chore(config): centralize node version management in config.json - #6479
Merged
Merged
Conversation
yhabib
changed the title
yhabib
marked this pull request as ready for review
February 24, 2025 06:37
dskloetd
approved these changes
Feb 24, 2025
1 task
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
…6488) # Motivation Following up on #6479, we want to use the Node version defined in `config.json` throughout our project to maintain a consistent approach to the Node version. This PR updates the last two references to `.nvmrc`. # Changes - Changes `NODE_VERSION` source from `.nvmrc` to `config.json`. # Tests - Actions should run as before. # Todos - [ ] Add entry to changelog (if necessary). Not necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Following up on #6431, we aim to establish a single source of truth for the node version in the project. To remain consistent with other versions, we will use the one defined in
config.json.Note: Some GitHub actions currently use
.nvmrcto determine the node version. These will be changed in a follow-up PR.Changes
NODE_VERSIONfrom theDockerfileas it was not used..nvmrcfromconfig.jsonand exposed it as an npm script..nvmrcfrom tracked files since it can now be generated locally.READMEwith local development instructions and information about.nvmrc.Tests
Todos
Not necessary