Skip to content

chore(node): update Node.js version in Dockerfile and config.json #6431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yhabib merged 2 commits into from
Feb 17, 2025
Merged

chore(node): update Node.js version in Dockerfile and config.json #6431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdd3282
update node to 18.20
yhabib Feb 15, 2025
e63c965
fix tests
yhabib Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ SHELL ["bash", "-c"]
RUN mkdir -p config
COPY dfx.json dfx.json
COPY config.json config.json
ENV NODE_VERSION=16.17.1
ENV NODE_VERSION=18.20.5
Comment thread
yhabib marked this conversation as resolved.
RUN jq -r .dfx dfx.json > config/dfx_version
RUN jq -r '.defaults.build.config.NODE_VERSION' config.json > config/node_version
RUN jq -r '.defaults.build.config.DIDC_RELEASE' config.json > config/didc_version
Expand Down
2 changes: 1 addition & 1 deletion config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
},
"build": {
"config": {
"NODE_VERSION": "18.14.2",
"NODE_VERSION": "18.20.5",
"IC_WASM_VERSION": "0.6.0",
"IDL2JSON_VERSION": "0.8.8",
"OPTIMIZER_VERSION": "0.3.6",
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/tests/lib/components/reporting/ReportingNeuronsButton.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ describe("ReportingNeuronsButton", () => {

const expectedCsv = [
"NNS Account Principal ID,xlmdg-vkosz-ceopx-7wtgu-g3xmd-koiyc-awqaq-7modz-zf6r6-364rh-oqe",
'Export Date Time,"Oct 14, 2023 12:00 AM"',
'Export Date Time,"Oct 14, 2023 12:00 AM"',
"",
",,Neuron ID,Project Name,Symbol,Neuron Account ID,Controller Principal ID,Stake,Available Maturity,Staked Maturity,Dissolve Delay,Dissolve Date,Creation Date,State",
',,="1",Internet Computer,ICP,d0654c53339c85e0e5fff46a2d800101bc3d896caef34e1a0597426792ff9f32,1,30.00,0.0000001,0,"3 hours, 5 minutes",N/A,"Jan 1, 1970",Locked',
Expand Down
10 changes: 5 additions & 5 deletions frontend/src/tests/lib/components/reporting/ReportingTransactionsButton.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,11 @@ describe("ReportingTransactionsButton", () => {
"Balance(ICP),1'234'567.8901",
"Controller Principal ID,xlmdg-vkosz-ceopx-7wtgu-g3xmd-koiyc-awqaq-7modz-zf6r6-364rh-oqe",
"Transactions,2",
'Export Date Time,"Oct 14, 2023 12:00 AM"',
'Export Date Time,"Oct 14, 2023 12:00 AM"',
"",
",,TX ID,Project Name,Symbol,To,From,TX Type,Amount(ICP),Date Time",
',,1234,Internet Computer,ICP,d0654c53339c85e0e5fff46a2d800101bc3d896caef34e1a0597426792ff9f32,d4685b31b51450508aff0331584df7692a84467b680326f5c5f7d30ae711682f,Sent,-1.0001,"Jan 1, 2023 12:00 AM"',
',,1,Internet Computer,ICP,d0654c53339c85e0e5fff46a2d800101bc3d896caef34e1a0597426792ff9f32,d4685b31b51450508aff0331584df7692a84467b680326f5c5f7d30ae711682f,Sent,-1.0001,"Jan 1, 2023 12:00 AM"',
',,1234,Internet Computer,ICP,d0654c53339c85e0e5fff46a2d800101bc3d896caef34e1a0597426792ff9f32,d4685b31b51450508aff0331584df7692a84467b680326f5c5f7d30ae711682f,Sent,-1.0001,"Jan 1, 2023 12:00 AM"',
',,1,Internet Computer,ICP,d0654c53339c85e0e5fff46a2d800101bc3d896caef34e1a0597426792ff9f32,d4685b31b51450508aff0331584df7692a84467b680326f5c5f7d30ae711682f,Sent,-1.0001,"Jan 1, 2023 12:00 AM"',
].join("\n");

expect(spySaveGeneratedCsv).toBeCalledWith(
Expand Down Expand Up @@ -170,7 +170,7 @@ describe("ReportingTransactionsButton", () => {
id: "1234",
project: "Internet Computer",
symbol: "ICP",
timestamp: "Jan 1, 2023 12:00 AM",
timestamp: "Jan 1, 2023 12:00 AM",
to: "d0654c53339c85e0e5fff46a2d800101bc3d896caef34e1a0597426792ff9f32",
type: "Sent",
},
Expand Down Expand Up @@ -200,7 +200,7 @@ describe("ReportingTransactionsButton", () => {
},
{
label: "Export Date Time",
value: "Oct 14, 2023 12:00 AM",
value: "Oct 14, 2023 12:00 AM",
},
],
},
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/tests/lib/services/sns-sale.services.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ describe("sns-api", () => {
expect(get(toastsStore)).toMatchObject([
{
level: "error",
text: "There is an existing participation started at Jan 1, 1970 12:00 AM. Completing that participation.",
text: "There is an existing participation started at Jan 1, 1970 12:00 AM. Completing that participation.",
},
]);
expect(ticketFromStore()?.ticket).toEqual(testTicket);
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/tests/lib/utils/reporting.utils.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ describe("reporting utils", () => {
id: "1234",
project: "Internet Computer",
symbol: "ICP",
timestamp: "Jan 1, 2023 12:00 AM",
timestamp: "Jan 1, 2023 12:00 AM",
to: "d0654c53339c85e0e5fff46a2d800101bc3d896caef34e1a0597426792ff9f32",
type: "Received",
},
Expand Down Expand Up @@ -288,7 +288,7 @@ describe("reporting utils", () => {
},
{
label: "Export Date Time",
value: "Oct 14, 2023 12:00 AM",
value: "Oct 14, 2023 12:00 AM",
},
],
},
Expand Down Expand Up @@ -331,7 +331,7 @@ describe("reporting utils", () => {
},
{
label: "Export Date Time",
value: "Oct 14, 2023 12:00 AM",
value: "Oct 14, 2023 12:00 AM",
},
];

Expand Down