Skip to content

Conversation

ilbertt
Copy link
Member

@ilbertt ilbertt commented Aug 4, 2025

Description

Use the effective canister id to delete the node keys from the local cache. The fix was already applied in https://github.com/dfinity/agent-js/pull/1081/files#diff-1deee5c6f68eb82e2be634c32d050e818f857292ed0fa9c9e19026e2ef60869cR980-R981, but here we clean the code a bit more and update the changelog.

Additionally, avoids throwing an error in Promise.all.

How Has This Been Tested?

Same tests should still pass.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

… map

Additionally, avoids throwing an error in `Promise.all`.
@ilbertt ilbertt requested a review from a team as a code owner August 4, 2025 16:27
Copy link
Contributor

github-actions bot commented Aug 4, 2025

size-limit report 📦

Path Size
@dfinity/agent 48.15 KB (-0.1% 🔽)
@dfinity/assets 53.21 KB (-0.04% 🔽)
@dfinity/auth-client 19.38 KB (0%)
@dfinity/candid 13.22 KB (0%)
@icp-sdk/core 91 B (0%)
@dfinity/identity 18.81 KB (0%)
@dfinity/identity-secp256k1 33.03 KB (0%)
@dfinity/principal 4.44 KB (0%)
@dfinity/use-auth-client 59.09 KB (-0.03% 🔽)

@ilbertt ilbertt merged commit b4fd8d1 into main Aug 5, 2025
35 of 47 checks passed
@ilbertt ilbertt deleted the luca/SDK-2249-effective-canister-id-subnet-keys branch August 5, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants