Skip to content

fix: enable certificate freshness check in canister status request #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 56 commits into from
Aug 5, 2025
Merged

fix: enable certificate freshness check in canister status request #1082

merged 56 commits into from
Aug 5, 2025

Conversation

ilbertt
Copy link
Member

@ilbertt ilbertt commented Jul 25, 2025 •
edited
Loading

Description

Enables the certificate freshness check when getting the canister status response.

Additionally, if the certificate freshness check fails, it now syncs time and retries once.

Blocked by #1081.

How Has This Been Tested?

Added e2e tests.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/agent 48.14 KB (-0.03% 🔽)
@dfinity/assets 53.13 KB (-0.15% 🔽)
@dfinity/auth-client 19.38 KB (0%)
@dfinity/candid 13.22 KB (0%)
@icp-sdk/core 91 B (0%)
@dfinity/identity 18.85 KB (+0.26% 🔺)
@dfinity/identity-secp256k1 33.03 KB (0%)
@dfinity/principal 4.44 KB (0%)
@dfinity/use-auth-client 58.97 KB (-0.21% 🔽)

@ilbertt ilbertt mentioned this pull request Jul 27, 2025
Merged
4 tasks
@ilbertt ilbertt marked this pull request as ready for review July 28, 2025 14:45
@ilbertt ilbertt requested a review from a team as a code owner July 28, 2025 14:45
@ilbertt ilbertt requested a review from mraszyk July 28, 2025 14:47
ilbertt and others added 13 commits August 4, 2025 15:30
@ilbertt
test: refine certificate creation tests logic
2830e41
@ilbertt
test: add more cases for certificate freshness checks
cc1c01c
@ilbertt
chore: update changelog
ad20d57
@ilbertt
fix: address PR feedback
5ff4b96
@ilbertt
docs: timeDiffMsecs jsdocs
efc9e5d
@ilbertt
docs: timediffmsecs jsdocs
331b454
@ilbertt
fix: we don't need the timeDiffMsecs param
5f27310
@ilbertt @mraszyk
Apply suggestion from @mraszyk
de5e3af 
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
@ilbertt @mraszyk
Apply suggestion from @mraszyk
5bfc26d 
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
@ilbertt
Merge remote-tracking branch 'origin/luca/SDK-2204-clock-drift-certif…
e2489d6 
…icate' into luca/SDK-2203-enable-certificate-freshness-checks
@ilbertt
refactor: remove unneeded function
6d65f6d
@ilbertt
refactor: we don't need to check for root key again
ec0c7da
@ilbertt
docs: remove comment
279e1dd
@ilbertt ilbertt requested review from mraszyk and nathanosdev August 4, 2025 19:46
mraszyk
mraszyk reviewed Aug 5, 2025
View reviewed changes
Base automatically changed from luca/SDK-2204-clock-drift-certificate to main August 5, 2025 09:21
@ilbertt ilbertt merged commit aa1dea6 into main Aug 5, 2025
28 checks passed
@ilbertt ilbertt deleted the luca/SDK-2203-enable-certificate-freshness-checks branch August 5, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mraszyk mraszyk mraszyk approved these changes

+1 more reviewer

@nathanosdev nathanosdev nathanosdev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ilbertt @nathanosdev @mraszyk